Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This could be positively construed as a feature request, but since I consider it a regression in the user experience from the previous tracker, I'm going to initiate this as a bug.
Previously, when I updated an issue with a new comment, I would be shown the new issue. The URL would be the permalink to the new comment in the thread and I could easily review my comments for typos and grab the URL to paste into a discussion, tweet, e-mail, etc.
Now, when I update an issue with a new comment, because I have to use the node edit form I end up at the top of the node page - even in cases where I've followed a link from the bottom of the thread. (Incidentally, that's another good reason why that link is misleading.)
What I expect to happen is to start typing in my comment, realize I want to update the metadata at the same time, cut my comment text, click the "Update this issue" link, update the issue with my comment, click submit, and then be redirected to the new comment added to the issue. (That's a bit of a tongue in cheek process, but I have to say that 95% of the time I forget I have to use the new form.)
I leave it up to the reader to determine a solution and to differentiate between new comments vs. simply issue summary updates; it's gonna be hard since we don't have a permalink yet to link to in the destination query parameter, but I'm sure a solution will present itself. : )
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | nodechanges-2133545-redirect-to-the-newly-posted-comment-fix-2.patch | 1.05 KB | formatC'vt |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedfwiw, the real frustration here hearkens back to the problems with the update process in general: it's become a process devoid of context. In this case, the form submission should be accompanied by a display of what was actually submitted. As is, "Update this issue" is just a process fork disguised as a local action or something.
Comment #2
klonosDisclaimer: I really miss this too for D6 d.o, so I agree with considering it a regression and thus being a bug - not a feature request.
If we are to re-introduce this, then we need to also move the green "issue updated" message close to the comment that was just added. Just a note.
Comment #3
tvn CreditAttribution: tvn commentedComment #4
alexander_danilenko CreditAttribution: alexander_danilenko commentedi'll take it
Comment #5
mgiffordConfirming that this is still an issue.
Also, where did the #new anchor go?
Comment #6
tvn CreditAttribution: tvn commentedComment #7
drummThis one could be tricky to implement.
The call to
comment_save()happens innodechanges_node_update(), but setting$form_state['redirect']needs to happen in a form-related function.nodechanges_node_update()does set$node->nodechanges_cid, so there is change that can be checked for late in the form submission process. Maybe a#submitthat is executed after node module does its work.Comment #8
formatC'vt CreditAttribution: formatC'vt commentedmaybe
drupal_goto()helps us?Comment #9
drummThis should be setting #redirect in somewhere in form altering or processing.
Comment #10
formatC'vt CreditAttribution: formatC'vt commentedstolen from
comment_form_submit()=)Comment #11
formatC'vt CreditAttribution: formatC'vt commentedhmm,
empty()is not right choiceComment #14
dwwTested locally. Works great, both with and without paged comments. Pushed patch from #11 as commit a934f47d. Pushed a few minor code style nitpicks as commit e43b3c50. Now this just needs deployment.
Thanks!
-Derek
Comment #15
drummPackaged beta4 and deployed to Drupal.org.