Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is from https://drupal.org/comment/8151919#comment-8151919 for separate tracking. Thanks to @dandaman for starting!
Comment | File | Size | Author |
---|---|---|---|
#2 | mp3player-2139711-2.patch | 1.93 KB | markie |
Comments
Comment #1
markie CreditAttribution: markie commentedComment #2
markie CreditAttribution: markie commentedSo now that we are comfortable here. I wrote that serialization so long ago, I don't even know why. I guess documentation would be nice, right? I found in my test site, $item['data'] was always null, so I wonder if I pulled that in from the 7.x branch. I'll take a closer look. Going to go ahead and move that if statement out into the main function which should resolve your issue. That being said.. probably should still know why it's there in the first place, right? Patch attached..
Comment #3
asb CreditAttribution: asb commentedThe patch does not apply cleanly against the dev release from drupal.org, neither with -p0 nor -p1.
Other/related issues: When the module is activated, I get an WSOD when accessing Views pages that include the player, and when accessing
./admin/reports/status
. Also, none of the players at./admin/settings/mp3player/player
can be edited. So, as far as I can the tell, the module is totally broken and is not of much use at the moment.