[D7] Webform Multiple File

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxChalk2151949git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Copy-pasted function comments, like:

/**
* Implements _webform_theme_component().
*/
function _webform_theme_multiple_file() {

/**
* Implements _webform_edit_component().
*/
function _webform_edit_multiple_file($component) {

and other functions.

Manual review:

Upon uploading a file i get this error:
Warning: Illegal string offset 'fid' in webform_multiple_file_managed_file_submit() (line 531 of /var/www/mysite/sites/all/modules/webform_multiple_file/webform_multiple_file.webform.inc).

@Chalk
I have tested your module and found that the code does not follow drupal standards.
All functions should be prefixed with your module name to avoid name clashes.

For your convenience, have a look at the issues pointed out in the link.
http://pareview.sh/pareview/httpgitdrupalorgsandboxchalk2151949git

manual review:

1. please describe the differences to webform_multifile on your project page so that users don't get confused about the purpose of this module.
2. _webform_render_multiple_file(): do not call theme() here, just add to the nested render array; Drupal will render the whole array later for you.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, Chalk!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.