Seems that general "entity_type" (ex: taxonomy term) can't be translated because is not correctly handled on "metatag_translate()" function.

Attached a patch trying to resolve this issue, working on "metatag_entity_view()" level, trying to detect the right instance.

Please review the patch, i'm not really sure if this is the right approach.

CommentFileSizeAuthor
#15 metatag-n2153977-15.patch810 bytesdamienmckenna
#10 metatag-n2153977-10.patch926 bytesdamienmckenna
#3 metatag-i18n-string-bundle-2153977-2.patch783 bytespaolomainardi
#1 metatag-i18n-string-bundle-2153977.patch1.5 KBpaolomainardi

Comments

paolomainardi’s picture

paolomainardi commented
StatusFileSize
new metatag-i18n-string-bundle-2153977.patch1.5 KB

Status: Needs review » Needs work

The last submitted patch, 1: metatag-i18n-string-bundle-2153977.patch, failed testing.

paolomainardi’s picture

paolomainardi commented
StatusFileSize
new metatag-i18n-string-bundle-2153977-2.patch783 bytes

Please find attached the right patch.

paolomainardi’s picture

paolomainardi commented
Status: Needs work » Needs review
paolomainardi’s picture

paolomainardi commented
Title: I18N metatag string translation broken » [PATCH] I18N metatag string translation broken
paolomainardi’s picture

paolomainardi commented
Issue summary: View changes
paolomainardi’s picture

paolomainardi commented

Up

paolomainardi’s picture

paolomainardi commented

up

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: [PATCH] I18N metatag string translation broken » I18N metatag string translation broken

FYI you don't need to bump issues, I will get to them.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2153977-10.patch926 bytes

Rerolled. I haven't tested it yet.

paolomainardi’s picture

paolomainardi commented

Thanks Damien and sorry for bumping, but i was in a hurry.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I wonder if all such definitions of $instance should be modified in the same way?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2175021: META: Plan for Metatag 7.x-1.0-rc1 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2175021: META: Plan for Metatag 7.x-1.0-rc1 release » #1269728: META: Plan for Metatag 7.x-1.0 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2153977-15.patch810 bytes

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks paolomainardi!

paolomainardi’s picture

paolomainardi commented

Thanks a lot @DamienMcKenna :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.