Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Reroll the patch if it no longer applies. | Yes | Instructions | |
| Update the issue summary | Yes | Instructions | |
| Embed before and after screenshots in the issue summary | Novice | Instructions |
Reported by jessebeach at #2154589-4: Edit breaks when the entity title is promoted to the page title (discovered by backporting):
We should change the cursor to a text cursor, especially for field like title which is a link. It doesn't seem editable with a point. So something like this.
div.edit-editing, p.edit-editing, span.edit-editing, input.edit-editing, a.edit-editing { cursor: text; }
| Comment | File | Size | Author |
|---|---|---|---|
| #31 | 2154775-31-in-place-cursor.patch | 1.72 KB | yvesvanlaer |
| #21 | chrome-1-after.png | 31.37 KB | gippy |
| #21 | chrome-1-before.png | 29.61 KB | gippy |
| #19 | 2154775-fix-missing-cursor-19.patch | 981 bytes | er.pushpinderrana |
| #19 | interdiff-2154775-12-19.txt | 395 bytes | er.pushpinderrana |
Comments
Comment #1
InternetDevels CreditAttribution: InternetDevels commentedIt looks like Chrome bug (in Firefox caret is visible). Also text looks messy with many words (attachment), so I've fix it with "display: inline-block". Caret is visible now.
Comment #2
Wim Leers#1: maybe you've succeeded in working around that browser bug that makes the caret invisible, but… at the same time, you seem to have broken the styling?
Comment #3
Wim LeersComment #4
kirkkalaPatch did not apply - needed to apply it manually and needs to be rerolled since it seem to be breaking functionality on Chrome (OS X): Title becomes uneditable as the tooltip covers the fiield.
Comment #5
kirkkalaCaret visible now, tested on Firefox & Chrome (OS X). Also fixed the issue with title breaking on multiple lines.
Found out the invisible caret is actually a contenteditable chrome bug, see https://code.google.com/p/chromium/issues/detail?id=170148 and proof at http://html5demos.com/contenteditable
Comment #6
kirkkalaComment #7
xjmComment #8
minneapolisdan CreditAttribution: minneapolisdan commentedComment #9
dcam CreditAttribution: dcam commentedPatch no longer applies.
Comment #10
dcam CreditAttribution: dcam commentedForgot the status, sorry.
Comment #11
Barnettech CreditAttribution: Barnettech commentedI'm working on this ....
Comment #12
Barnettech CreditAttribution: Barnettech commentedThe directory structure had changed so the old patch wouldn't apply.
Comment #13
Barnettech CreditAttribution: Barnettech commentedforgot to change this to needs review.
Comment #14
bdevore CreditAttribution: bdevore commentedDoesn't appear to work for me on osx Chrome using the simplytest.me from dreditor to test...
Comment #15
nsuit CreditAttribution: nsuit commentedThis still applies cleanly. I removed the Needs reroll tag.
Comment #16
jbennett CreditAttribution: jbennett commentedThis worked for me in OS X with Chrome 35 and other browsers. This didn't work right away because of caches so make sure they are cleared for you.
Looks good to me.
Comment #17
andyguzman CreditAttribution: andyguzman commentedOn OSX, Chrome 35/Firefox 29/Safari 7 all work after clearing browser and site cache.The cursor does appear now when clicking into the box, but with a long title the .quickedit-editable class field gets messy again when quick edit mode is enabled as mentioned in #1 of this thread.
Comment #18
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedComment #19
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedI hope this patch would look better. I am also adding screenshot here:
Before:
After:
Comment #20
gippy CreditAttribution: gippy commentedI tested patch 19 with all five browsers. For four of the five browsers on OS X (Chrome, Safari, Opera, Firefox) patch 19 worked exactly as is shown in the screenshots in 19 above. The patch also worked with Internet Explorer 11 on Windows 7. In all cases a long title caused there to be boxes around each word. After the patch, the long title was properly enclosed in a single box.
However, I had to upgrade Internet Explorer from 9 to 11 in order to get the quickedit icon to appear (core/misc/icons/bebebe/pencil.svg). I tried configuring Internet Explorer 9.0.26 many ways to get the .SVG icon to appear, without any success.
This link has the following statement: "Internet Explorer 9 does not display SVG graphics that were created using the ODS HTML destination. Use the ODS HTML5 destination to create SVG graphics that are to appear in Internet Explorer 9. Internet Explorer 9 does not support animated SVG graphics. For animated SVG graphics, use Internet Explorer 8 or another browser. Certain settings are required for Inline SVG files in HTML5 output to display in Internet Explorer 9 . If the SVG file looks similar to the following output and does not display any graphic, you must set the Browser Mode and the Document Mode to properly view the SVG file.
corrupted inline svg image as it appears in IE9"
http://support.sas.com/documentation/cdl/en/graphref/66521/HTML/default/...
I'm new at this. Is this a known issue for Internet Explorer 9? Does this resolve the current issue? Should a new issue be opened for rendering with IE 9?
Comment #21
gippy CreditAttribution: gippy commentedPatch 19 was tested in five browsers and found to work properly. A related issue was uncovered about the pencil.svg icon not appearing in Internet Explorer 9, but being resolved in Internet Explorer 11. A new issue was opened for that problem. Changing the status to "tested and reviewed".
Comment #22
gippy CreditAttribution: gippy commentedTested and reviewed per comment 21.
Comment #23
webchickOh, great! This has been really annoying me. :)
Committed and pushed to 8.x. Thanks! Sorry for this sitting around so long; my post-DrupalCon life got a bit hectic.
Comment #25
Wim LeersI have my doubts about this patch. Was this tested in themes other than Bartik? What if a theme uses
display:inlineorwidth: 50%or something like that? The committed patch would break in such scenarios AFAICT.Comment #26
Wim LeersThis will also need to be backported to D7: #1893638: [Firefox bug] Cursor doesn't show up when using the "direct" or "ckeditor" PropertyEditor widgets.
Comment #27
Wim LeersI just manually tested #2226493: Apply formatters and widgets to Node base fields. Because of this patch, fields that are rendered inline are rendered as blocks as soon as in-place editing is enabled. That's a huge regression.
This confirms the fears I expressed at #25. It might be better to next time wait for a component maintainer to RTBC fragile things like this :)
Comment #28
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedComment #29
webchickOk, reverted for now. Guess this means it's also not a novice issue.
Comment #31
yvesvanlaer CreditAttribution: yvesvanlaer commentedHey all
The cursor was blocked by the "background-color" css styling.
This styling was the result of a part of javascript code.
By removing the javascript code I was able to fix this issue.
I have attached a patch, enjoy!
Comment #32
Wim LeersManually tested. Conclusion:
Thank you very much for the fix — as you can tell from this issue's history, we've been figuring out a way for some time to get it fixed, so it's wonderful to have you jump in and just fix it in a very simple way! :)
I hope we'll see more from you, Yves! :)
Comment #33
Wim LeersComment #34
alexpottCommitted 61215d0 and pushed to 8.0.x. Thanks!
Comment #36
Wim LeersHurray! Congrats, @yvesvanlaer, with landing your very first Drupal core patch :)
Comment #37
nod_