I found a change record notice that did not have the project set today. This meant it didn't appear on
https://drupal.org/list-changes/drupal/
That is a critical problem. The Project field is not currently required on Change Record nodes and it really really needs to be.
In addition, we need to look through existing ones and make sure their Project field is set, in case any other glitches are there.
A small additional thing: the "Updates done" section fieldset should be closed by default. It really isn't being used much. I think we could also get rid of the help text under the Description field. By this time, people do understand how to write them. :)
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2156217_v3.patch | 4 KB | jthorson |
Comments
Comment #1
dwwWhile critically annoying, I don't think this really qualifies as a critical bug for d.o... It sucks if some change records are missing their project reference, but it's not bringing the site down like #2136119: Text search on issue queues is slow and sometimes WSODs for example.
That said, this should be easy to fix. Everything about change records lives in drupalorg/features/drupalorg_change_notice -- it should be pretty trivial to roll a patch for this. I'd tag it "novice" but I don't know if anyone's still using that. ;)
Thanks for reporting the problem.
Cheers,
-Derek
Comment #2
tvn commentedQuick update: we still have 2 Critical issues to deal with and a few Major ones. So we won't get to this one this week, and probably not next week.
We do have dev sites if anyone wants to re-create change records feature. First step would be to request SSH key added to our dev server. Instructions are here: https://drupal.org/node/1018084
Comment #3
jthorson commentedHere's a re-rolled feature patch.
Comment #4
jthorson commentedHmmm ... looks to be some extra crud in there that I wasn't expecting. In any case, this should be enough of a start to get things moving!
Comment #5
jhodgdonSome of those changes look to be the usual artifacts of rerolling a Feature.
But some of them are not desirable, such as the one that removes the Description help text from the Description field.
Comment #6
jthorson commentedThat was intentional ... based on your comment in the OP:
I'm not sure I agreed, but did it anyway. Happy to reverse it. :)
Comment #7
jhodgdonDoh! :)
Comment #8
jthorson commentedComment #9
jthorson commentedOoops ... missed the project name change.
Comment #10
xjm@drumm checked with me about this issue--it should probably go in after #2151041: Add a "draft" status for change records.
Also, I think the field defaulted to core before the D7 upgrade (or could be passes in the URL maybe?) but doesn't now.
Comment #11
tvn commentedThere is http://test-drupal.redesign.devdrupal.org/, which is our good old D6 D.o to test how things were when needed.
Comment #12
drummCommitted & deployed.
Comment #13
jhodgdonDid look in the database for change records created without the Project set, before this change went in? Those should probably be set to Drupal Core.
I don't think there is currently a way to filter those in the deployed views for Change Notices on d.o, but it should be an easy query to set up?
Comment #14
drummUpdated:
https://drupal.org/node/2133117
https://drupal.org/node/2137545
https://drupal.org/node/2138591
https://drupal.org/node/2139569
https://drupal.org/node/2144561
https://drupal.org/node/2155247
https://drupal.org/node/2166881
https://drupal.org/node/2168121
https://drupal.org/node/2174429
https://drupal.org/node/2185953
They were all Drupal core, except one for Workflow.