Problem/Motivation

As identified in #2169547: Incompatibility with workbench_moderation 7.x-2.x, the API in Workbench Moderation v2 has changed from what Metatag currently supports.

Proposed resolution

Fix it.

Remaining tasks

@todo

User interface changes

?

API changes

?

Original report by @username

As identified in #2169547: Incompatibility with workbench_moderation 7.x-2.x, the API in Workbench Moderation v2 has changed from what Metatag currently supports.

CommentFileSizeAuthor
#2 metatag-integration-w-wmv2-2169575-2.patch1.13 KBgvorbeck

Comments

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Issue summary: View changes
gvorbeck’s picture

gvorbeck commented
Status: Active » Needs review
StatusFileSize
new metatag-integration-w-wmv2-2169575-2.patch1.13 KB

Hey Elijah, I discussed with Duran and we've been using the two modules together for quite some time without issue. There isn't actually any incompatibility anymore. There may have been at one time, but no longer. This patch will remove that message.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-integration-w-wmv2-2169575-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@gvorbeck: So does that mean that WM 2 uses standardized entity functions to do its work, rather than the custom callbacks it used to use?

ericduran’s picture

ericduran commented

@DamienMcKenna We've been using both of them perfectly fine.

Is there a feature that we're missing? I think #2 is the correct fix.

gvorbeck’s picture

gvorbeck commented
StatusFileSize
new metatag-integration-w-wmv2-2169575-6.patch1.32 KB

Here's a version of the patch file that shouldn't fail this time.

gvorbeck’s picture

gvorbeck commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #1269728: META: Plan for Metatag 7.x-1.0 release

@ericduran: That's excellent news, thanks for chiming in. I'll add this to 1.0.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed, though I adjusted the note in the README.txt file accordingly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.