Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The Real time poll module provides a result poll block that allows the users of a
site to see realtime results of the last poll that relies on the Node JS
server provided by the Node.js module .
Next step: integration with Poll Block module
https://drupal.org/sandbox/jmaerckaert/2171607
git clone --branch master jmaerckaert@git.drupal.org:sandbox/jmaerckaert/2171607.git real_time_poll
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjmaerckaert2171607git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
pachabhaiya CreditAttribution: pachabhaiya commentedDear jmaerckaert,
Reviewing your code manually, I found some major issues which you should correct.
1. You should remove master branch. Please check this link (http://drupal.org/node/1127732) to learn about moving your master branch to the major version branch.
2. You should also remove LICENSE.txt (drupal.org packaging will automatically include this file)
3. real_time_poll.info file should include all required properties. (name = ... and core = ... ) are the required properties. 'core = ...' is missing in your info file. Please check this documentation to get more idea about creating .info file (https://drupal.org/node/542202)
You can check other general errors by using the online tool (pareview.sh).
Cheers!!!!
Comment #3
jmaerckaert CreditAttribution: jmaerckaert commentedDear c.pachabhaiya,
I fixed all issues.
I didn't know pareview.sh.
It's a very great tool.
Regards,
Jonathan
Comment #4
pachabhaiya CreditAttribution: pachabhaiya commentedHi Jonathan,
I see, you're still using 'master' branch. It is highly recommended to use the major version branches (e.g., 7.x-1.x) instead of master branch.
Please refer to this article (https://drupal.org/node/1127732) to learn more about moving master branch to major version branch.
Cheers!!!
Comment #5
jmaerckaert CreditAttribution: jmaerckaert commentedHi c.pachabhaiya,
It's done.
Regards
Comment #6
jmaerckaert CreditAttribution: jmaerckaert commentedComment #7
freddybushboy CreditAttribution: freddybushboy commentedAside from you still needing to delete the master branch after creating your major version branch, all looks good to me and works fine :-)
Master branch still being reported here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxjmaerckaert2171607git
Comment #8
freddybushboy CreditAttribution: freddybushboy commentedComment #9
jmaerckaert CreditAttribution: jmaerckaert commentedHello Fred,
I deleted the master branch.
Cheers.
Comment #10
jmaerckaert CreditAttribution: jmaerckaert commentedComment #11
jmaerckaert CreditAttribution: jmaerckaert commentedComment #12
PA robot CreditAttribution: PA robot commentedProject 1: https://drupal.org/node/2177781
Project 2: https://drupal.org/node/2171629
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #13
jmaerckaert CreditAttribution: jmaerckaert commentedComment #14
jmaerckaert CreditAttribution: jmaerckaert commentedComment #15
jmaerckaert CreditAttribution: jmaerckaert commentedComment #16
nicorac CreditAttribution: nicorac commented1) Your GIT clone command is wrong:
git clone --branch master jmaerckaert@git.drupal.org:sandbox/jmaerckaert/2171607.git real_time_poll
Use the public HTTP one with the right branch so users won't be asked for jmaerckaert's GIT password:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jmaerckaert/2171607.git real_time_poll
2) You suggest into README.txt to extract your module in "sites/all/modules/contrib" folder.
I also like to group my modules by functionality using subfolders, but I think this choice is up to the final (mostly advanced) user.
Including it into INSTALL.txt could be a risky choice and could generate questions like "I don't have such folder on my site" from unexperienced users... Keep your issue queue clear ;)
Good luck for your module.
Comment #17
joachim CreditAttribution: joachim commentedPlease fix your git clone command in the summary!!!
> This module adds Node.js integration to Drupal.
Really? surely you mean in a particular piece of Drupal.
You don't need to tell users how to install a module. d.org has documentation on that.
If $poll is a loaded node, then it must have a nid. No need to check. If you're not sure that node_load() will get you a node, you need to check it's not FALSE. But you're calling node_load() based on a query for a nid, so you're fine.
These are wrong.
Missing param docs. And this function's code could do with a bit of commenting inside to explain the manipulations its doing.
This isn't a hook, it's a submit handler.
Comment #18
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.