Getting errors like:

Notice: Undefined property: stdClass::$type in _metatag_entity_is_page() (line 1373 of /xyz/code/sites/all/modules/contrib/metatag/metatag.module).

I have a patch that I'll attach

CommentFileSizeAuthor
#6 metatag-n2172883-6.patch1.4 KBdamienmckenna
#1 metatag-notice-undefined-property-2172883-1.patch969 byteskristen pol

Comments

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-notice-undefined-property-2172883-1.patch969 bytes

Here's the trivial patch

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Hmm... that patch is getting rejected when I use it. I used:

git format-patch origin/7.x-1.x --stdout

from:

[#1054616]

and am trying to apply it on my project with:

patch -p1 < [filename]

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Needs work

Ah... I think our code is a bit outdated... moving back to needs work.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

I tried with git diff too and it still didn't work... argh. I'm giving up for now.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2172883-6.patch1.4 KB

Thanks for spotting something is up. It actually needs to verify the entity_type is 'node' before doing anything else, rather than use $entity_type.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks for noticing something was up, Kristen.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.