While going over the README.txt, I noticed a few minor spelling errors. And after having recently been reproached by Jenkins/PHPCS for improper use of "e.g." on a different project (it should be "e.g.," apparently), I noticed a few of those too.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | metatag-n2173271-5.patch | 4.13 KB | damienmckenna |
Comments
Comment #1
deetergp commentedComment #2
deetergp commentedmetatag-spelling-2173271-1.patch addresses the issues I found in the README.txt file.
Comment #3
damienmckennaI grew up in Ireland and we didn't use commas after "i.e." and "e.g.", that usage is an American thing, per Wikipedia: http://en.wikipedia.org/wiki/E.g.#cite_note-6
Comment #4
deekayen commentedYou, Dave Reid, Dries, drupal.org, and the Drupal Association are all in the USA - I think that's probably a good reason to follow the "American thing."
Comment #5
damienmckennaNot disputing it, just noting it as I didn't realize there was a difference on the syntax between the different countries.
Here's a patch that wraps one of the lines at 80 chars.
Comment #6
damienmckennaCommitted. Thanks!