Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Recently ran into the scenario where the 4096 limit was not enough for IE9 (thinking that media queries are counted towards the total, despite that supposedly not being true).
As a result we needed to lower the count and an interface option for changing this value seemed the best approach. Attached is a patch for 7.x-2.4 that adds this functionality.
The only thing I feel uncertain of here is the value being passed to the YUI compressor in advagg_css_compress module.... it was at 4096 (not 4095) so maybe this was a nice binary number for a reason and passing in some arbitrary number has performance implications.
Great module by the way!
Alex
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | advagg-2181209-5-IE-selector-limit-value.patch | 845 bytes | aschmoe |
| #1 | advagg-2181209-1-IE-selector-limit-value.patch | 4.21 KB | mikeytown2 |
| advagg-make_ie_selector_value_configurable.patch | 3.72 KB | aschmoe | |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedThe YUI compressor will output a new line character after 4k of text, makes it easier to look at in text editors. I've committed all changes except for the changes to advagg_css_compress as that change shouldn't affect the problem you've been having with IE9. Did some slight modifications to your patch as well :)
Comment #2
aschmoe CreditAttribution: aschmoe commentedGreat, thank you.
Comment #4
aschmoe CreditAttribution: aschmoe commentedHi Mikey,
Looks like you have had some regression on this. With 7.x-2.5 (and the current dev branch) you're pulling in the variable, but just checking against a raw "4095" value.
Alex
Comment #5
aschmoe CreditAttribution: aschmoe commentedPatch attached for 7.x-2.5.
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commented#5 has been committed