Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Email Blacklist provide administrator to configure blacklisted users email ids, to whom system will never send any type of mail.
Features:
- Administrator can add/remove blacklisted users email ids.
- System will automatically detect blacklisted email ids and it will not allow to send any email to those users.
The sandbox project URL : https://drupal.org/sandbox/vishal_yug/2204461
Setting Git Repo:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/vishal_yug/2204461.git email_blacklist
cd email_blacklist
Reviews of other projects:-
https://drupal.org/comment/8521287#comment-8521287
https://drupal.org/comment/8522989#comment-8522989
https://drupal.org/comment/8565097#comment-8565097
Comment | File | Size | Author |
---|---|---|---|
#21 | email_blacklist-fixed_admin_form_validate_function-2204535-21.patch | 1.68 KB | SGhosh |
#4 | admin-email-blacklist.png | 11.98 KB | contactvishaljain |
Comments
Comment #1
gobinathmvishal_yug, there are few problem with the project application & module.
1. info file contains module version, this is discourage as drupal.org package manager automatically does this.
2. You need to follow the checklist for application submission. http://pareview.sh/pachecklist
3. Application with Review Bonus takes highest priority. You can review other project application & provide those links in your description. Please review minimum of 3 application.
4. PAReview is reporting issue on the code. Please see http://pareview.sh/pareview/httpgitdrupalorgsandboxvishalyug2204461git
5. Module have minor functional issue. eg. when i tried to enter 4 email id's in configuration, it only stored 2.
once you are done with all the fixes change the status to Needs Review
Comment #2
contactvishaljain CreditAttribution: contactvishaljain commentedComment #3
contactvishaljain CreditAttribution: contactvishaljain commentedComment #4
contactvishaljain CreditAttribution: contactvishaljain commentedComment #5
contactvishaljain CreditAttribution: contactvishaljain commentedComment #6
contactvishaljain CreditAttribution: contactvishaljain commentedErrors found by Pareview fixed and other issues also fixed.
Comment #7
Fernly CreditAttribution: Fernly commentedHi vishal_yug,
I removed the PAReview: review bonus tag. You need 3 reviews to use this tag.
Also remove your username from the git clone link.
Manual review
Comment #8
contactvishaljain CreditAttribution: contactvishaljain commentedHi lennartvv,
I have corrected the $form as point 2.
For point #1, This module is intended for both registered user as well as non-registered users. For a non-registered users may be arise in some cases like (Tell a friend, Promotional emails etc.). So I have created a separate db table to store those blacklisted email ids.
Comment #9
contactvishaljain CreditAttribution: contactvishaljain commentedComment #10
contactvishaljain CreditAttribution: contactvishaljain commentedComment #11
contactvishaljain CreditAttribution: contactvishaljain commentedComment #12
alinouman CreditAttribution: alinouman commented1- you are not validating email address while submitting value in admin form.
2- project is too short to approve you as full module creator. May be git admin approved this only project for you.
3- Do 3 manual review and add review tag.
Comment #13
contactvishaljain CreditAttribution: contactvishaljain commentedThanks, alinouman,
1. I have add the validation of email ids that are saved, under the admin configuration.
2. I know the project its short but once its first release we can add email (module key) based blocking of email sent out. That will be more useful.
Comment #14
contactvishaljain CreditAttribution: contactvishaljain commentedComment #15
contactvishaljain CreditAttribution: contactvishaljain commentedComment #16
TanvirAhmad CreditAttribution: TanvirAhmad commentedI am not sure which IDE you are using, but I cheked it usin NetBeans, and found your code formating issue with function email_blacklist_mail_alter, here
are not properly formated.
Comment #17
TanvirAhmad CreditAttribution: TanvirAhmad commentedComment #18
contactvishaljain CreditAttribution: contactvishaljain commentedHi TanvirAhmad,
I have checked with Netbeans IDE and fixed the formatting stuff.
Comment #19
contactvishaljain CreditAttribution: contactvishaljain commentedComment #20
subhojit777Fix the code review issues: http://pareview.sh/pareview/httpgitdrupalorgsandboxvishalyug2204461git
Rather than creating a new table for storing blacklist email addresses, why do not make use of variables table. Create a system setting form (https://api.drupal.org/api/drupal/modules!system!system.module/function/system_settings_form), this way the setting will be stored in a variable. You can then easily check settings through variable_get(). This way you can make more use of Drupal API.
It would be good to keep all .inc files in a separate directory calles
includes
. Keep admin.inc file inside includes directory.Comment #21
SGhosh CreditAttribution: SGhosh commentedCleaned up the code for the admin form validate function. Attaching a patch for the same. Please do refer the patch, test it and may be use it too :)
Code changes and reasons for the same -
* added required to the email form field
* instead of replacing new line with comma and splitting on comma, split directly on new line or whitespace
* if incorrect email found, break loop
* no need of changing form field value in $form_state variable
More feedback coming up after some more review :)
Feedback
Comment #22
SGhosh CreditAttribution: SGhosh commentedUpdated previous. Please ignore this.
Comment #23
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.