[D7] Anchor Menu Items

Hi robin.ingelbrecht,

PAReview is reporting issue on the code. Please see http://pareview.sh/pareview/httpgitdrupalorgsandboxrobiningelbrecht22056....

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@vishal_yug, please perform full manual review.

@robin.ingelbrecht suggestion on the application request.

1. Please update your project description to include an non-maintainer version of GIT repo clone command.
2. Project applications with Review bonus takes priority. So please complete manual reviews & include those url's here. Once done, please include appropriate tags in the application.

Note: the above comments are not based on project review. Those are simple suggestion on project application.

Hi Robin,

1. In validation anchor_menu_items_validate
You are validation only 1st part of link path instead you have to check the whole path after .

2. Condition for 2 anchor tags is not handled?
Ex. //abc

3. Condition for anchor tag at other position i.e. except 1st position is not handled
Ex. abc/ OR abc/xyz/

No objections, everything looks good and clean!
Works perfectly!

@simon.westyn
You may not set status to RTBC without reviewing the application.

@robin.ingelbrecht
Can you explain please (on the project's page) what is so extra your module does that Drupal core does not provide by default? "#" sign can be used normally in menu items.

Robin, I hate to tell you this, but there is another module that will allow you to do this very thing.

1.2 Ensure your project is not a duplication

Check out the Menu Token module: https://www.drupal.org/project/menu_token

Not only does it allow you to add anchors, but it also allows query strings and tokens.

Postponed, according to last 2 comments. Please, add a description of how your project differs from others.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2346321

Project 2: https://www.drupal.org/node/2205693

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.