Patch to follow.

Comments

lsolesen’s picture

Status: Active » Needs review
StatusFileSize
new1.94 KB
carsonblack’s picture

Assigned: Unassigned » carsonblack

testing this patch at the sprint

carsonblack’s picture

The last two lines will fail due to a bug with permalink that is preventing the redirect:

Given I go to "testing-title"
Then the response status code should be 301

I haven't found an issue for this bug yet, but if I can't I will create one and link it. However, these two lines SHOULD be put back into this test once that bug is fixed as it would be correct to test for that behavior. I will not this and link back to this issue in the issue for the permalink bug.

Also, on line 35 of the patch:
Then the response status code should be 200
Inside the "Scenario: Pathauto should keep old url when changing the title"
The response code should be a 404 as changing the title should not change the path. Therefore, going to "completely-other-title" should cause a 404 not a 200.
I am creating a patch to reflect these changes.

carsonblack’s picture

Status: Needs review » Needs work
carsonblack’s picture

Status: Needs work » Needs review
StatusFileSize
new1.86 KB

Here is the patch!

dsnopek’s picture

Status: Needs review » Fixed

@carsonblack: Thanks! It works for me, so - committed. :-)

Can you make a new issue describing the bugs with panopoly_admin interfering with Pathauto that we investigated at the sprint? Thanks!

  • Commit b0810f6 on 7.x-1.x authored by carsonblack, committed by dsnopek:
    Issue #2213649 by carsonblack, lsolesen: Added Behat test for pathauto...
dsnopek’s picture

There appears to be a legitimate failure when updating from 1.0-rc3:

https://travis-ci.org/panopoly/panopoly/jobs/27016765

I haven't had a chance to look into it, but I assume it's some Pathauto setting thats setup by default on 1.0-rc4 and later, but not set in a hook_update_N() function.

I've made a new issue for this:

#2282833: Pathauto tests failing after update from 1.0-rc3

carsonblack’s picture

I have created issue 2283223 which covers the permalink redirect bug.

carsonblack’s picture

@dsnopek I think this could be related to not setting the Update Action setting in pathauto to "Create new alias. Leave the existing alias functioning". I mention this in Issue# 2283223.

dsnopek’s picture

Thanks, Carson!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.