Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Tests / Continuous Integration
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
8 Mar 2014 at 16:07 UTC
Updated:
24 Jun 2014 at 11:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lsolesen commentedComment #2
carsonblack commentedtesting this patch at the sprint
Comment #3
carsonblack commentedThe last two lines will fail due to a bug with permalink that is preventing the redirect:
I haven't found an issue for this bug yet, but if I can't I will create one and link it. However, these two lines SHOULD be put back into this test once that bug is fixed as it would be correct to test for that behavior. I will not this and link back to this issue in the issue for the permalink bug.
Also, on line 35 of the patch:
Then the response status code should be 200Inside the "Scenario: Pathauto should keep old url when changing the title"
The response code should be a 404 as changing the title should not change the path. Therefore, going to "completely-other-title" should cause a 404 not a 200.
I am creating a patch to reflect these changes.
Comment #4
carsonblack commentedComment #5
carsonblack commentedHere is the patch!
Comment #6
dsnopek@carsonblack: Thanks! It works for me, so - committed. :-)
Can you make a new issue describing the bugs with panopoly_admin interfering with Pathauto that we investigated at the sprint? Thanks!
Comment #8
dsnopekThere appears to be a legitimate failure when updating from 1.0-rc3:
https://travis-ci.org/panopoly/panopoly/jobs/27016765
I haven't had a chance to look into it, but I assume it's some Pathauto setting thats setup by default on 1.0-rc4 and later, but not set in a hook_update_N() function.
I've made a new issue for this:
#2282833: Pathauto tests failing after update from 1.0-rc3
Comment #9
carsonblack commentedI have created issue 2283223 which covers the permalink redirect bug.
Comment #10
carsonblack commented@dsnopek I think this could be related to not setting the Update Action setting in pathauto to "Create new alias. Leave the existing alias functioning". I mention this in Issue# 2283223.
Comment #11
dsnopekThanks, Carson!