[D7] Find People

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmanimjs_drupal2250975git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Your code is pretty, but you have some coding standards errors.

For example on line 31 found 3 spaces when standards said 2 indentation, for this case expected 4 spaces.

See it please: https://drupal.org/node/318

In line 57 you need put a . when finish line...

Put into description git link

Ahhh you remember remove master branch ;)

Otherwise, if you solve this errors code is good :)

Works fine for my in drupal 7.28

@manimjs_drupal

If you need more visibilty to approved faster your module see Review Bonus -> https://drupal.org/node/1975228

Add into master issue http://pareview.sh/pareview/httpgitdrupalorgsandboxmanimjs_drupal2250975git see: https://drupal.org/node/2258001 ;)

manimjs_dr
Clean and Simple code. Module works in terms of functionality.
1. I see the same functionality with more filters available in the other module ->Admin Views. https://drupal.org/project/admin_views It provides similar functionality at the same page with extra filters like 'email','Role' and operations like 'delete','Change value', 'Send Email'
2. We prefer Collaboration over competition.
https://drupal.org/developing/modules
3. Also the project page has no link to the Git repository. It should have git clone --branch 7.x-1.x http://git.drupal.org/sandbox/manimjs_drupal/2250975.git find_people
4. Also the number of lines for the module to get published should be more than 200.

Please fix these.

1. I see the same functionality with more filters available in the other module ->Admin Views. https://drupal.org/project/admin_views It provides similar functionality at the same page with extra filters like 'email','Role' and operations like 'delete','Change value', 'Send Email'
Re: Admin_views provides separate views to handle this people page. But some of people want to search people only by username or email without taking too much effort in implementation. So we are moving to this module. Here they just enable and enjoy with search options. Extra we are giving option to configure the search values. They can set option to search by username or email or else both.

On line 43 You've one coding standars error:

43 | ERROR | [x] Expected 1 space after "=>"; 2 found

Found using pareview

This minor coding standard error is surely not an application blocker, please do a real manual review.

XD

OK @klausi I din't put it on my manual reviews for speed up my revision. I've read the manual revision guidelines https://groups.drupal.org/node/427683.

I was only checking other issues to learn how people affort this validation process.

Thankyou so much anyway.

<3

Hi!

Your module seems to work pretty well, and the code looks good to me!

I do think you should rename your admin_config file to find_people.admin.inc though.

also, in find_people_admin_config.inc:

line 33, "Any one search field is required" sounds a bit awkward, maybe reword it so it reads: "Please select at least one search option." or something like that.

aside from those pretty minor things (and make sure to run pareview again) though, I'm setting this to RBTC.

Thanks everyone for review this. I have updated your feedback's and submit for review. As well i have added some validation process when user do search by e-mail itself. Kindly have look at this.

you module is looks nice and working very well for me.
but i have a featured request page reload is is seems to some slow behavior.
i should be great if you add ajax or load suggestions/autocomplete field.
thanks!

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2401587

Project 2: https://www.drupal.org/node/2251329

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.