Description:

This project provide formatter for file field creating unordered and ordered list.

When we need create a list of files we've this formatter to generate two list method.

Other information:

Manual reviews of other projects

Comments

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

keopx’s picture

Issue summary: View changes
keopx’s picture

Issue summary: View changes
keopx’s picture

Issue tags: +PAreview: review bonus
keopx’s picture

Issue summary: View changes
a_thakur’s picture

Status: Needs review » Reviewed & tested by the community

Pareview code review does not throw any errors and after manually reviewing the code, I don't see any major issues. Installed the module on drupal 7.26 and don't see any errors.

In your .info file I see dependency on php 5.3.x, whereas I have tested the module on php 5.4.x and did not see any errors, I think that dependency is safe enough to be removed.

juampynr’s picture

README.txt could follow the official template https://drupal.org/node/2181737

<?
/**
* @file
* Implemented hooks for the filelist_formatters module.
*/
?>
We could rephrase this to "Hook implementations for filelist_formatters module"

Apart from that, code looks neat.

keopx’s picture

Priority: Normal » Major

More than 2 week on this status.

klausi’s picture

Issue summary: View changes
Issue tags: -PAreview: review bonus

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

keopx’s picture

Issue summary: View changes
keopx’s picture

Issue summary: View changes
keopx’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
mpdonadio’s picture

pareview.sh came up clean.

Not seeing any duplication issues, though I think you could accomplish this with Display Suite or Fences.

Remove the 7.x-1.0-beta1 tag from the repo. Don't tag a beta until you are sure you have the module the way you want.

The description in your README.txt doesn't need quotes.

Project page looks good; like the screenshots.

The README is a little lean, you could fill it out a little more and/or follow the template from https://drupal.org/node/2181737

Long term, you may want to consider a version that will work with File Entity.

Very minor point, but you aren't consistent with single- vs double-quotes. See https://drupal.org/coding-standards#quotes

There aren't a lot of inline comments, but it is mostly all standard code.

Not seeing any security or third-party code issues. API usage is very good.

mpdonadio’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, keopx!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

keopx’s picture

Thanks for information.

I cleared all minor issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.