[D7] node_generator

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxankitgarg2261805git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi ankitgarg,

Before reviewing your project in detail I would suggest you to correct the project path given i.e. "git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ankitgarg/2261805.git node_generator".
And please make sure to delete master branch as well.

Also have a look at suggestions given at #2

Thanks

Hi, cool submission! Here are my nitpicks/comments, in no particular order:

1. In the admin form, the bolding of the help text appears to be wrong. (Specifically, it seems like the "or element#id" should not be bold). Also there is help text at the very bottom of the page, "Note:- Please use pattern only for class or id" that I think belongs closer to the fields it is about. It also needs to be explained a bit - does this mean that only a subset of CSS selectors are valid?
2. It needs to be more clear in the admin form help text, or at least in the README, that the XML file is intended to be a sitemap.xml, as opposed to an RSS feed or something else. I didn't realize this until I looked in the "sample xml" directory.
3. It's not clear what the "Content Pattern" populates. I assumed (correctly) that it was the Body field, but I didn't know for sure until I checked the module code.
4. There should be some sort of a "preview" function for testing the patterns, prior to starting the import. I started an import of 2000+ pages, and it has been going for quite a while without successfully saving any nodes. So I think my selectors didn't work, but can't know without closing the browser tab and starting over with different selectors.
5. A more general comment and bit of advice is that this is a rather hard-coded way of doing something that the Migrate module is also well-suited for. I like that node_generator does a lot of stuff for you, like copying files, etc, however I think that you are missing out on the work that has happened with Migrate. Migrate does have a "wizard" API for UI-generated dynamic migrations, so I could definitely see this module implemented as a Migrate wizard. It becomes much more flexible this way (such as field mappings, which is huge) and also Migrate imports very fast.
6. I have been running an import as I've typed this up, and after about an hour it has only gotten through 100 items, and none of them successfully created a node. So I'm finding it difficult to actually test this. I'd recommend, not only for the benefit of testers but also for users, that you include a walkthrough that includes a sample XML file with actual live links to content (say, 10 or so pages that contain images) and instructions for what to put in the patterns. This way users could see how a successful run behaves.
7. Since you're using a third-party library, it seems like it would be more "correct" to expose simple_html_dom using the Libraries module.
8. I don't think the node_generator.js file needs to be loaded in hook_init(), since it's only needed on the admin form.

Hope this helps, good luck!

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2267323

Project 2: https://drupal.org/node/2262881

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.