The Twitter Cards specifications indicate that "twitter:image:src" should be used, so "twitter:image" seems to have been dropped or was a mistake.

CommentFileSizeAuthor
#6 metatag-n2267501-6.patch4.63 KBdamienmckenna
#2 metatag-n2267501-2.patch2.36 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2175021: META: Plan for Metatag 7.x-1.0-rc1 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2267501-2.patch2.36 KB

This patch replaces the meta tag, updates the README.txt, and adds an update script to replace update existing records.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-n2267501-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2298337: Add structure in API for meta tags to replace others

In addition to a reroll, this is dependent upon #2298337: Add structure in API for meta tags to replace others.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Postponed
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2267501-6.patch4.63 KB

This improves the update script so that it also fixes metatag_config, and then also fixes the default value from metatag_twitter_cards_metatag_bundled_config_alter.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed » Needs review

Unblocked.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

  • DamienMcKenna committed 7fab856 on 7.x-1.x 
    Issue #2267501 by DamienMcKenna: Renamed the 'twitter:image' meta tag to...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed, though I did split the update script in two, just to avoid possible timeouts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andrew_mallis’s picture

andrew_mallis commented
Priority: Major » Minor
Status: Closed (fixed) » Needs work

Looks like Twitter spec is now twitter:image again instead of twitter:image:src.
Not seeing anything breaking currently.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Minor » Major
Status: Needs work » Closed (fixed)

Lets take this up in a new issue: #2550001: Twitter went back to using twitter:image instead of twitter:image:src