It seems that the Views integration was broken in #2186155: Metatags corrupted when saving translated entities programmatically and needs some repair.

CommentFileSizeAuthor
#15 metatag-n2341795-15.patch2.61 KBdamienmckenna
#12 metatag-n2341795-12.patch5.92 KBdamienmckenna
#9 metatag-n2341795-9.patch5.3 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2341821: META: Plan for Metatag 7.x-1.2 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Closed a duplicate: #2343199: Impossible to override meta in views

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Closed a duplicate: #2346839: Metateg not saved in views.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Critical

Bumping this to "critical" as it involves data loss / corruption.

darksnow’s picture

darksnow
Location Scotland
commented

HI.

I know this has only been broken for eleven days or so but is there an ETA on repair?

It also seems to be affecting the stable 7.x-1.1 release, so when fixed will there be a new stable release so we can update our sites? I can see the parent issue assigned here, but wanting to clarify.

Thanks for the great work.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@darksnow: As soon as the items listed as child issues on #2341821: META: Plan for Metatag 7.x-1.2 release are completed (including this one) I'll be releasing v7.x-1.2.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Closed another duplicate: #2349063: Metatag for views : overwrite not working

matthieu_collet’s picture

matthieu_collet commented

Thank you Damien. But have you got an idea of the date for 1.2 release ? we have lost a lot of ranking :(

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2341795-9.patch5.3 KB

This appears to resolve the problem.

matthieu_collet’s picture

matthieu_collet commented

Yes! thank you Damien, it works!

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented 
+++ b/metatag_views/metatag_views.module
@@ -28,8 +28,8 @@ function metatag_views_views_preview_info_alter(&$rows, $view) {
+    dpm($metatags);

I don't think you meant to leave the dpm() here, did you?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2341795-12.patch5.92 KB

Doh. Please try this one.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed d812fd4 on 7.x-1.x 
    Issue #2341795 by DamienMcKenna: Updated Metatag:Views to be compatible...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Needs review
StatusFileSize
new metatag-n2341795-15.patch2.61 KB

The previous commit had a bug in the preview handling.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.