- activate "metatag_panels" module
- save some metatags for a page (/admin/structure/pages)

The value gets saved in database table "page_manager_handlers" (field "conf").

But if you open the settings form again (e.g. /admin/structure/pages/nojs/operation//handlers/_panel_context/meta) the saved value does not appear as prefilled form value.

Comments

libelle2000’s picture

StatusFileSize
new889 bytes
damienmckenna’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Needs work

I've a gut feeling that the problem should be handled in metatag_panels..

MauPalantir’s picture

StatusFileSize
new602 bytes

I think this is because the form is saved incorrectly with a language key in it. This also prevents metatag_panels from working on pages. I attached another approach to fix both the form and metatag display, but on the long term, this inflexible form language selection method could cause other problems.

damienmckenna’s picture

Status: Needs work » Needs review
Parent issue: » #2350761: META: Plan for Metatag 7.x-1.3 release

Lets get fix this in the next release.

The last submitted patch, 1: metatag_panels_form_prefill_2344877.patch, failed testing.

damienmckenna’s picture

StatusFileSize
new903 bytes

I think this is the correct approach, given the new module convention of storing data for multiple languages.

  • DamienMcKenna committed c77d425 on 7.x-1.x
    Issue #2344877 by DamienMcKenna, Mau Palantír, libelle2000: Fixed Panels...
damienmckenna’s picture

Status: Needs review » Fixed

Committed. Thank you all for your help.

karlshea’s picture

Status: Fixed » Needs work

This isn't fixed. When I save the Meta tag configuration on my panel page I see that it's getting saved since my Feature is overridden but the values do not show up in the form. They also don't get rendered to the page.

I see in metatag_metatags_form() that the saved values are passed in, but there's an und key in the array that looks like it's getting ignored.

karlshea’s picture

StatusFileSize
new1.65 KB

This is what I added to get loading saved values and rendering to work, but I'm only using title and description in my panel.

If it's ignoring the language code halfway through metatag_metatags_form() I can't imagine other forms are working right either.

karlshea’s picture

StatusFileSize
new1.73 KB

Updated patch to fix error when first enabling metatags for panel variant.

damienmckenna’s picture

This needs to be completely handled in metatag_panels.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new1.07 KB

I have such a feeling of deja vu... I could have sworn I fixed this already, guess I never uploaded the patch :(

This should work.

karlshea’s picture

Status: Needs review » Reviewed & tested by the community

Ahhh I see why it looked like metatag_metatags_form() was the culprit instead.

The patch works for me, but the data had to be re-entered in the pane to work right (not a big deal in my case).

damienmckenna’s picture

StatusFileSize
new1.98 KB

Do your previous settings work with this patch?

damienmckenna’s picture

Status: Reviewed & tested by the community » Needs review
karlshea’s picture

Status: Needs review » Reviewed & tested by the community

Yes, I reverted to the old feature and applied the new patch to metatag and they showed up just fine.

When I exported the feature again, it also didn't export with the 'und' key in the data.

torgospizza’s picture

Confirming that with this patch my Panels Pages meta tags now show up (and save) correctly. Thank you!

damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the reviews. Committed.

  • DamienMcKenna committed ffe5426 on 7.x-1.x
    Issue #2344877 by DamienMcKenna: Fixed Panels integration, for real this...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

juzzuu’s picture

Version: 7.x-1.x-dev » 7.x-1.4
Assigned: Unassigned » juzzuu
Status: Closed (fixed) » Needs work

Hello.
Metatags are still not showing up. Installed u brand new Drupal site, Panels, Panels Everywhere, Metatags 7.x-1.4 and cTools.
Everything is working,but when I use Panels-everywhere the metatags don't show up.

damienmckenna’s picture

Version: 7.x-1.4 » 7.x-1.x-dev
Assigned: juzzuu » Unassigned
Status: Needs work » Closed (fixed)

Please open a new issue as the original bug was fixed, but evidently something needs further examination, possibly based upon interactions with another module.

Also, when you set the "Assigned" field to your name it means you're going to work on the issue.