Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Panels integration
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2014 at 14:21 UTC
Updated:
27 Oct 2014 at 20:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
libelle2000 commentedComment #2
damienmckennaI've a gut feeling that the problem should be handled in metatag_panels..
Comment #3
MauPalantir commentedI think this is because the form is saved incorrectly with a language key in it. This also prevents metatag_panels from working on pages. I attached another approach to fix both the form and metatag display, but on the long term, this inflexible form language selection method could cause other problems.
Comment #4
damienmckennaLets get fix this in the next release.
Comment #6
damienmckennaI think this is the correct approach, given the new module convention of storing data for multiple languages.
Comment #8
damienmckennaCommitted. Thank you all for your help.
Comment #9
karlsheaThis isn't fixed. When I save the Meta tag configuration on my panel page I see that it's getting saved since my Feature is overridden but the values do not show up in the form. They also don't get rendered to the page.
I see in metatag_metatags_form() that the saved values are passed in, but there's an und key in the array that looks like it's getting ignored.
Comment #10
karlsheaThis is what I added to get loading saved values and rendering to work, but I'm only using title and description in my panel.
If it's ignoring the language code halfway through metatag_metatags_form() I can't imagine other forms are working right either.
Comment #11
karlsheaUpdated patch to fix error when first enabling metatags for panel variant.
Comment #12
damienmckennaThis needs to be completely handled in metatag_panels.
Comment #13
damienmckennaI have such a feeling of deja vu... I could have sworn I fixed this already, guess I never uploaded the patch :(
This should work.
Comment #14
karlsheaAhhh I see why it looked like metatag_metatags_form() was the culprit instead.
The patch works for me, but the data had to be re-entered in the pane to work right (not a big deal in my case).
Comment #15
damienmckennaDo your previous settings work with this patch?
Comment #16
damienmckennaComment #17
karlsheaYes, I reverted to the old feature and applied the new patch to metatag and they showed up just fine.
When I exported the feature again, it also didn't export with the 'und' key in the data.
Comment #18
torgospizzaConfirming that with this patch my Panels Pages meta tags now show up (and save) correctly. Thank you!
Comment #19
damienmckennaThanks for the reviews. Committed.
Comment #22
juzzuu commentedHello.
Metatags are still not showing up. Installed u brand new Drupal site, Panels, Panels Everywhere, Metatags 7.x-1.4 and cTools.
Everything is working,but when I use Panels-everywhere the metatags don't show up.
Comment #23
damienmckennaPlease open a new issue as the original bug was fixed, but evidently something needs further examination, possibly based upon interactions with another module.
Also, when you set the "Assigned" field to your name it means you're going to work on the issue.