If you create a submission guideline for a node it will not show on the node creation page as expected. This is because template_preprocess_pane_messages() calls a theme called 'help'. However, Drupal 7 does not have such a theme. Instead the Drupal 7 system Help block calls menu_get_active_help() and so should template_preprocess_pane_messages() .

This should fix any situation where help messages should be displaying.

CommentFileSizeAuthor
#1 panels_everywhere-n2346255-1.patch523 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new panels_everywhere-n2346255-1.patch523 bytes

Like this?

magicmyth’s picture

magicmyth commented
Status: Needs review » Reviewed & tested by the community

Heh. Thats exactly what I did in that file and was intending to add a patch. In my alteration though I also altered the pane-messages.tpl.php to wrap the help message so it can be styled more directly as normally it can be targeted with .block-system-help like so:

- <?php print $help; ?></div>
+ <?php if($help): ?><div class="system-help"><?php print $help; ?></div><?php endif; ?>

Of course this is easy to override in a theme but I figured it is a sensible default to have.

Anyway that patch works just fine so RTBC.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks for raising the issue. I don't see any reason to add extra wrappers around the help messages as core doesn't, so if a specific site needs it then they should customize it as necessary.

  • DamienMcKenna committed 2a11deb on 7.x-1.x 
    Issue #2346255 by DamienMcKenna, magicmyth: Wrong method of outputting...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.