Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Views integration
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Oct 2014 at 20:41 UTC
Updated:
29 Oct 2014 at 14:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaSorry. :-(
Comment #2
damienmckennaI've confirmed the problem. Dangit :(
Comment #3
mloveridge17 commentedDoes 'confirming' the problem mean that your first comment, #1 is null and that this is a bug to be fixed in 7x-1.4?
Comment #4
damienmckennaI've confirmed the bug exists, and that I want to fix it for the next release. I've not found a solution, neither has anyone else posted a working patch therefore I can't say when a fix will be available.
Comment #5
damienmckennaI believe this should work.
The problem stemmed from logic changes in options_summary() that were incorrect.
Comment #6
damienmckennaComment #7
pkiff commentedI'm the one whose post is quoted in the issue description. I have tested the same two installations with this newest patch, applied to metatag 7.x-1.3. This patch appears to resolve the issue in the two cases I am working with.
I have not reviewed any of the code, but just checked to see that the Meta Tags section appears correctly in the Views UI, regardless of whether that view is using default or overridden values. All looks good to me.
Thanks for continuing to work on this today, Damien. Metatags is a very helpful module, and I find it especially valuable for producing properly tagged Views pages.
Comment #8
damienmckenna@pkiff: Thanks for the review, hopefully we'll have some others take a look too.
Comment #9
ofry commentedPatch #5 working fine! This problem has solved!
Comment #10
damienmckennaThanks for the reviews. I've committed the patch.
Comment #12
mloveridge17 commentedI'm slower than all y'all at implementing the fixes, but I finally got it in place and it looks to be working as expected.
@DamienMcKenna Thank you so much for all of your efforts on this module. It is greatly appreciated!
Comment #13
lquessenberry commentedWorked for me.