Plugin filter process should not return string [#2678016]

Comment	File	Size	Author
#4	plugin_filter_process-2678016-4.patch	1.88 KB	GoZ
#3	plugin_filter_process-2678016-3.patch	1.3 KB	GoZ

Comment #1

29 February 2016 at 15:44

GoZ created an issue. See original summary.

Log in or register to post comments

Comment #3

GoZ CreditAttribution: GoZ commented 29 February 2016 at 15:47

Status:

Active

» Needs review

File	Size
plugin_filter_process-2678016-3.patch	1.3 KB

Here is a path to fix this issue.

Log in or register to post comments

Comment #4

GoZ CreditAttribution: GoZ as a volunteer commented 29 February 2016 at 15:57

File	Size
plugin_filter_process-2678016-4.patch	1.88 KB

1 file was hidden/shown/deleted

File	Size
plugin_filter_process-2678016-3.patch	1.3 KB

I also add here libraries.
I cannot make another issue since we use FilterProcessResult to add libraries.
So the attached patch is same as comment #3 with libraries (based on fact css and js files are in sites/all/libraries/prism as defined in README.txt)

Log in or register to post comments

Comment #5

rooby CreditAttribution: rooby commented 10 March 2016 at 02:27

I'm using this patch for the libraries addition and it is working as expected.

From a coding standards point of view the patch is fine too.

I'm not currently using the prism filter though so I haven't actually done testing on that aspect.

Log in or register to post comments

Comment #6

GoZ CreditAttribution: GoZ as a volunteer commented 10 March 2016 at 08:24

Issue summary:

View changes

Log in or register to post comments

Comment #7

scuba_fly

Netherlands, Vinkeveen

CreditAttribution: scuba_fly at LimoenGroen commented 11 May 2016 at 14:17

Status:

Needs review

» Reviewed & tested by the community

Confirming #4 works.

This could also work:
$text->setProcessedText(str_replace($search, $replace, $text->getProcessedText()));

if you replace the line return str_replace($search, $replace, $text);with above in PrismFilter.php

Log in or register to post comments

Comment #8

moonray CreditAttribution: moonray at Chapter Three commented 7 October 2016 at 14:41

The patch in #4 fixes a critical error. I didn't try the suggestion in comment #7.

Log in or register to post comments

Comment #9

Chroid CreditAttribution: Chroid at Sparks Interactive commented 31 October 2016 at 01:09

I can also confirm I'm receiving this error after a initial install and enabling of the module:

The website encountered an unexpected error. Please try again later.
Recoverable fatal error: Argument 1 passed to Drupal\Core\Render\BubbleableMetadata::merge() must be an instance of Drupal\Core\Cache\CacheableMetadata, string given, called in ...../core/modules/filter/src/Element/ProcessedText.php on line 113 and defined in Drupal\Core\Render\BubbleableMetadata->merge() (line 26 of core/lib/Drupal/Core/Render/BubbleableMetadata.php).

Applying @GoZ's patch from #4 resolves these issues immediately.

Should/could this be committed against dev so that every new install isn't killing people's sites as soon as it's enabled and used ?