Tabledrag doesn't hide columns when the whole table is initially hidden

oh, so THAT's why I'm having problems trying to add tabledrag compatibility to location.

Subscribing.

The header wasn't hiding either.

I ran into this with a collapsed fieldset containing a draggable table. Manually applying the patch solves the problem for me at least in Safari4beta and Opera9.6.

Any updates on this? WOuld really need this for Location module

New stuff and bugfixes go first to Drupal 7 to avoid regressions popping up. Needs review on D7.

Marked #339105: Tabledrag not hiding columns inside collapsed fieldsets as a duplicate of this issue.

This definitely needs work, as there's lots of cruft in tabledrag from getting it to work in older browsers. Please see this comment.

#425148: Form elements within a collapsed field group are not visible in Internet Explorer was marked as duplicate for this issue. Is it?
The symptoms mentioned here seems to be different then those mentioned there.

In addition can the above patch be applied for D6 as well or only D7?

thanks.

Keeping up to date with HEAD. Still needs review!

Tagging this with 'Usability'

This problem appeared together with cck multiple value fields, fieldgroup and vertical_tabs. To not patch the core itself I took the critical function (patched it) and put it in a separate js-file in my theme/js folder and I overwrote the function theme_content_multiple_values in the themes template.php like this:

function my_them_content_multiple_values($element) {
  $output = theme_content_multiple_values($element);
  
  drupal_add_js($GLOBALS['theme_path'].'/js/tabledrag-workaround.js', 'theme');

  return $output;
}

I attached the js-file (remove the txt-extension to use it).

TS:

Elements in a collapsed fieldset inherit the display: none setting, and tabledrag.js skips elements with display set to none. Skipping does not seem to be necessary.

This is no longer the case in D7 as collapse only hides the wrapper with class .fieldset-wrapper. Does this mean this issue is fixed for D7?

If it needs to be fixed why RTBC?

Should be needs review, as #22 still hasn't had anyone review it. :)

Looks good to me. Needs testing across major browsers.

#31: tabledrag.js-303189-31.patch queued for re-testing.

The index variable needs to be reset every time that we loop, in case there was a colspan and the index got adjusted.

In the meantime, there is now a working patch that leaves the Safari workaround in place:

#769520: tabledrag does not work on hidden tables

Marked #769520: tabledrag does not work on hidden tables as a duplicate of this issue.

#35: drupal7-tabledrag.js_303189.patch queued for re-testing.

The tabledrag JavaScript code in Drupal 7 seems to have changed a lot since the last patch was submitted, is this still an issue in D7?

Bump. Definitely still an issue in Drupal 6.

+1 subscribing, it needs to be fixed in D6 too.

New patch against HEAD, removed unused variable parentTag.

I hit this bug too. My drag table is in a vertical tab that is not the first one so it's not selected in the initial loading of the page.

subscribing

subscribe

Patch adapted a bit to clean up the var columnIndex. Patches correctly on both D7.2 and D8-dev. Works fine on D7.2 in firefox 4. Can anyone confirm and RTBC?

adding tag

I did some further testing myself, and on tables with a colspan in the header it went wrong :(. Over optimised by removing the var index. So I reintroduced this var but did optimise the jquery object creation in the remainder (use a var cells instead of a var row) and that does work fine.

Can anyone confirm and RTBC?

This fix also applies to the same bug when a table is initially hidden with #states.
It solves both. And the resulting code is easier to understand!

The patch in #53 works for Drupal 7 aswell.

Subscribing, ran into the same issue described in #45

Added an issue summary. It would probably be a good idea to state explicitly which browsers this has been tested in, and also confirm that the table behaves properly when the whole thing is not initially hidden.

Revamped issue summary.

Updated issue summary with vertical tabs example.

Added list of browsers for reference.

Removed a minor browser,and confirmed for browsers I tested.

Re-RTBC, the issue summary is updated.

Updated issue summary.

Well this looks like a great code simplification, and a bug fix. Nice!

Committed and pushed to 8.x and 7.x. Marking back to 6.x.

tested in FF 3.16 & Chrome 12.0.742

Looks good, same code. Maybe we want one more person to test the patch functionally on D6.

I just found this -- I had written a similar patch in a different, duplicate issue. I closed the other issue, http://drupal.org/node/842498#comment-5199120, for reference.

I have not tested vctoroc's patch -- it seems to make more dramatic alterations than I did, but the adjustment is very similar.

Something to note, this also affects JQuery Update module, since that module rewrites and replaces tabledrag. If this patch is accepted, would you re-file with JQuery update?

see: http://drupal.org/node/1298618

Note that you can type the issue number like so: #1298618: tabledrag.js does not work properly with CCK "collapsed" fieldset
To render a nice issue link like so: #1298618: tabledrag.js does not work properly with CCK "collapsed" fieldset

I'd just leave the jQ update issue you've already filed open. When this issue is fixed, that module can be updated as needed.

If you have the chance, could you test this patch and report the results? If you can confirm that it works, then we can mark this RTBC for D6.

cool i always wondered how people got those nicely formatted links...

I will test when i get a chance, unfortunately, however, i'm pretty buried at the moment and actually ditched the tabledrag field i was using so i won't be able to get into to it right away.

#60 worked for me in FF Mac 16.0.2.

All major browsers confirmed. I'm not going to quibble about Opera. ;)