Disable, uninstall Metatag: Google Plus (D8)

Agreed.

Removing modules gets tricky. We'll need to have an update script to uninstall the module, remove all values from configuration and entities, and blanking out some of the files, which we'll actually remove later.

In the issue fork I added two update hooks to the main module, the second of which is incomplete. I suppose we will also need a post_update hook to clean up content (make sure we only save config or content when it was actually updated, since this sort of stuff can take a while).

This is a good start, thank you.

The second update script needs to be refined to:

• Have one update script for updating the default configurations; this one doesn't need a sandbox.
• Another update script that modifies entity values stored in Metatag fields; this does need to use a sandbox.

I'm not sure how D8 handles things being deleted before the respective plugins are uninstalled, I'd be concerned at it blowing up sites. As such I think we should make the module "hidden" and physically delete the files later.

Let's get this into Metatag 2.0.0.

WIP patch based upon the PR. This needs work to update the configuration and update the per-entity values.

Needs work to finish the update scripts.

WIP on the update scripts and test coverage. Skipping test coverage, for now.

Working on this.

More progress.

So the update scripts don't work if metatag_google_plus has been removed already, so we might need to delete the files later in order to do the update script. Either that or move the update scripts to 8.x-1.x and delete the files in 2.0.x. Decisions, decisions.

Does this patch apply cleanly?

Oh, the patch doesn't apply because of the fixture file. Dangit.

I committed the fixture change separately so that the tests can run.

In order to avoid the conflict between configuration schema requirements and removing the files that contain the necessary schema, we might just have to skip testing the configuration changes. Or move the uninstall to 8.x-1.x and then remove the files in 2.0.x.

Because we can't guarantee that everyone will have updated to the newest 8.x-1.x release before upgrading to 2.0.x, we cannot assume that the update scripts would have been executed before the files disappeared. Therefore we need to hide the module in v2 and then plan for them to be removed in v3. *sigh*

However, some of the tags could be removed.

I can remove all of the tags and just leave the info file in place, that seems to work.

Removing even more bits!

Committed.

Need some follow-up to make the post-update script names to be generic so they can be reused for other tags that are being removed.

Renaming stuff.

Committed.

Needed to add more meta tags to the removal list.

All done.