CommentFileSizeAuthor
#2 3127420-2.patch317 bytesSuresh Prabhu Parkala
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Suresh Prabhu Parkala’s picture

Status: Active » Needs review
FileSize
317 bytes

Please review the patch.

Rajab Natshah’s picture

Status: Needs review » Reviewed & tested by the community

Please if you can spare time to commit this issue to the dev branch that will be nice.
A release after that will have a support for Drupal 9 build.
as this issue is a blocker issue for
#3122672: Start a 9.0.x branch for Varbase and Varbase Project to integrate with Drupal 9

Real physical testing with Drupal 9 is important as Drupal 9.0.4 went out

Thanks for having time to work on this nice and very useful module.

Rajab Natshah’s picture

Priority: Minor » Critical
Rajab Natshah’s picture

Suresh's patch is good to let the module be able to require it by composer for the Drupal 9
The issue #3127449: Drupal coding standards
Can follow for Drupal coding standard and Drupal Practice.

clemens.tolboom’s picture

Status: Reviewed & tested by the community » Fixed

Hmmm ... this is/was not complete as https://www.drupal.org/node/3119415 wants to remove

code: 8.x

and we have 8.9.x so new issue is welcome to remove the code

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.