Remove Shepherd shim code from Tour

Closed duplicate #3261249: Remove deprecated tour.module functions

Initial attempt to clean-up

fix cs

Lets see what tests bots will say.

Let me see if I can fix the errors.

New patch.

Just adding diff between #5 and #8

+++ b/core/modules/block/config/optional/tour.tour.block-layout.yml
@@ -21,21 +21,21 @@ tips:
+    selector: '.button--small'

Is quoting all these strings necessary? AFAIK, YAML should handle that just fine.

I did not do an investigation to check the motivation but there are some tests that fail when the quotes are not added. And the error complains only of those keys that don't have quotes.
For example the JsonApiUpdatePathTest or the MigrateDrupalUpdateTest that failed in patch #5.

+++ b/core/modules/tour/src/TourTipPluginInterface.php
@@ -9,9 +9,6 @@
- * @todo move all methods to TipPluginInterface and deprecate this interface in
- *   https://drupal.org/node/3195193

Not sure we can just remove this comment without doing the deprecation that it suggests?

@paulocs could you do a version of the patch without the quoting, just so we can see those test failures in isolation from the rest?

The removal of the @todo in #15 does seem unrelated to the rest of the changes since we're not actually changing anything in that class, although it's better to have an issue without a @todo than vice versa.

Here is a patch without the quotes, expected to fail, as suggested by @cathc .

+++ b/core/modules/tour/src/TourTipPluginInterface.php
@@ -9,9 +9,6 @@
  * @see \Drupal\tour\TipPluginBase
  * @see \Drupal\tour\TipPluginManager
  * @see plugin_api
- *
- * @todo move all methods to TipPluginInterface and deprecate this interface in
- *   https://drupal.org/node/3195193
  */
 interface TourTipPluginInterface extends TipPluginInterface {
 

IMO we should go ahead and remove this hunk from the patch - the issue it points to is still open, but given this passes tests without the config changes, looks RTBC to me otherwise.

@catch I am a bit confused.
The last patch #17 already removes the comment below from TourTipPluginInterface

+++ b/core/modules/tour/src/TourTipPluginInterface.php
@@ -9,9 +9,6 @@
  * @see \Drupal\tour\TipPluginBase
  * @see \Drupal\tour\TipPluginManager
  * @see plugin_api
- *
- * @todo move all methods to TipPluginInterface and deprecate this interface in
- *   https://drupal.org/node/3195193
  */
 interface TourTipPluginInterface extends TipPluginInterface {

And when you said:

the issue it points to is still open

I think it points to itself. https://drupal.org/node/3195193 is this issue here.

Hmm OK, I think it is me who's confused.

However this issue isn't deprecating or removing the method on TourTipPluginInterface so I think we should open a follow-up to do that.

So I created a follow-up for this issue and updated the link at TourTipPluginInterface.php to point to that issue.

Here is the follow-up #3276336: Move methods from TourTipPluginInterface and deprecate this interface. and the new patch.

Thanks looks good now.

Random test failure. Restoring status.

Another random test failure. Restoring status.

+++ b/core/modules/tour/src/TourTipPluginInterface.php
@@ -11,7 +11,7 @@
+ *   https://drupal.org/i/3261249

Is this the correct issue? That issue was closed as a duplicate for this.

Updated on commit to reference #3276336: Move methods from TourTipPluginInterface and deprecate this interface..

Committed f9bb5b8 and pushed to 10.0.x. Thanks!