Problem/Motivation

The code for this module needs to be updated to be compatible with Drupal 10.

Issue fork popin-3425549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Andrii Momotov created an issue. See original summary.

Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented
Assigned: Unassigned » Andrii Momotov

Andrii Momotov opened merge request !4

Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review
Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented
Assigned: Andrii Momotov » Unassigned
Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented

Changed popin.info.yml for Drupal 10 Compatibility. Please check.
Thanks!

RobbyMo’s picture

RobbyMo CreditAttribution: RobbyMo at CTAC commented
Version: 2.1.x-dev » 2.0.x-dev
Status: Needs review » Reviewed & tested by the community

Verified Drupal 10 compatibility issues resolved from merge request 4 on 2.0.x branch testing on Drupal 10.1.8.

I think this is a great little popup module. After configuring the popin settings and placing the block the popup displayed and cookie was set as expected.

One thing to note since 'core: 8.x' is not included in the popin.info.yml file this will not work with Drupal core versions below 8.7.7 - see https://www.drupal.org/node/3070687. If you would like for this to be usable on all Drupal 8 versions I would suggest adding the 'core: 8.x' to the file as well, otherwise updating the core_version_requirement to be ^8.8 || 9 || 10 will ensure that the module installs on the correct versions that recognize the core_version_requirement key.

Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented

Hi Rob,

Thank you for your review and reply!

Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented
Andrii Momotov’s picture

Andrii Momotov CreditAttribution: Andrii Momotov at DevBranch, Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.