Optional node revision task handler to override default behavior

I don't have specific plans to work on it. It's a question in there because I"m not sure that the override is needed. If it is, then it should be implemented. Which means we need to work in the right way to do it.

Care to submit a patch?

It's my belief that we need this in ctools, independant of the revisioning module. My use for node revisions is typically in the context of editorial workflow and approvals.

I've hijacked the patch provided in revisioning #519924: Panels integration fix and moved the node revisions task handler it into page manager - I've got it working for both 6 and 7 - only a couple of small tweaks were needed, but it certainly needs review.

The problem of overrides to the node revisions page handler by other modules needs addressing, and there are surely other aspects that someone more knowledgeable with ctools and its conventions should weigh in on.

If you can recommend further changes, I'm happy to make them.

The 7.x patch works well for me. I am using Panelizer and State Machine to create panels-based node layouts with revision-based workflows. This task plugin makes it so that revisions are able to be previewed on the revisions page.

Aside: For anyone trying to use this with panelizer, I had to manually add the panelizer task handler to this task after enabling it.

Scratch that.

Why does this task try to override node/%node and node/%node/view also? This makes it so that the the standard node_view task cannot be enabled. Removing the those overrides from the menu_alter works for me.

Yeah it shouldn't do both.

hmmm. In my use case, I wanted revisions to preview just like normal nodes. If revisions are to look just like normal nodes, then separating the node page handler from revision page handlers isn't desirable. You'd just have to keep them the same by hand, and that's a maintainability problem.

I've had clients asking "why don't my drafts have the same layout as my published versions?" enough times that it seemed like a reasonable default for the use cases I typically see.

That said, I can guess that the rest of the world might differ from those constraints. Is it possible that we provide a config option that allows for admins to decide if they want to use the revision handler for node/nid as well as node/nid/revision/vid? Merlin, what would you recommend?

I'd be happy to implement a solution that makes sense to everyone involved...

It seems like it could be a config option to just inherit the node_view task handlers or not. Most of the time that's probably what you want; but you don't want to redefine node_view, I wouldn't think.

I applied the D7 patch to my D7 instance but was getting 500 errors when saving nodes. I found out that the patch is telling ctools to call the callback "_page_manager_view_revision", but in the patch, nobody wrote the function... why would you refer to a callback and not write it???

Also, the paths in the patch make it so you have to apply the patch from your drupal docroot, I updated the patch so it reflects that we're working from the root of the ctools project.

This patch is better for my use-case. This doesn't override node/%node anymore, and removes the call to _page_manager_view_revision in favor of a call directly to node_page_view

Updated the last patch. file, page_manager_node_revision_view_disabled needs to be set False , otherwise user has to make "Node revision view" Disabled/Enabled for first time to make work the last patch.

Project page path is more general so that it should work for everyone. Place the patch under ctool module and apply the Patch.

Updated the last patch. file, page_manager_node_revision_view_disabled needs to be set False , otherwise user has to make "Node revision view" Disabled/Enabled for first time to make work the last patch.

Project page path is more general so that it should work for everyone. Place the patch under ctool module and apply the Patch.

Updated the last patch. file, page_manager_node_revision_view_disabled needs to be set False , otherwise user has to make "Node revision view" Disabled/Enabled for first time to make work the last patch.

Project page path is more general so that it should work for everyone. Place the patch under ctool module and apply the Patch.

Updated the last patch. file, page_manager_node_revision_view_disabled needs to be set False , otherwise user has to make "Node revision view" Disabled/Enabled for first time to make work the last patch.

Project page path is more general so that it should work for everyone. Place the patch under ctool module and apply the Patch.

Updated the last patch. file, page_manager_node_revision_view_disabled needs to be set False , otherwise user has to make "Node revision view" Disabled/Enabled for first time to make work the last patch.

Project page path is more general so that it should work for everyone. Place the patch under ctool module and apply the Patch.

Thanks for re-rolling the patch to fix my crufty paths.

I don't think we want to have the handler enabled by default. While the people following this issue of course want the Node Revision handler enabled for their use-cases, keep in mind that this patch is for CTools more generally. The mere act of enabling Page Manager should not automatically override node revision rendering (you'll note that none of the other handlers -- user, node, etc. -- are enabled by default).

Shouldn't this basically be a mirror of the current node action that just loads a specific revision, rather than a whole extra page handler unto itself? I'd imagine that's what most people would want, right? So, yes, this provides a new handler for the node/%node/revision/%/view path, but I don't think most people will want that.

FYI I created a sandbox project that lets you display node revisions using the Page Manager handler that's currently configured for node_view: http://drupal.org/sandbox/damienmckenna/1821404

@DamienMcKenna:

Seems like the cleanest way to integrate your project would be to just add it to the node_view task handler? I don't have any problem with that but wonder if there are use-cases for configuring/managing the node view and revision view handlers separately.

I have tried the patch from @azinck #20 and it didn't override the page at first. Then after disabling and enabling again it just gave me a "no access page" (site is in french so i can't remember what's actual english sentence by default)

So i removed the patch and used the sandbox module made by @DamienMcKenna and It works brilliantly. All it does is using the panel made for your nodes (which is what you'd expect).

Sandbox project in #24 is fantastic... Thanks!

Sandbox project in #24 is fantastic... Thanks!

Sandbox in #24 works perfectly, only thing left is to make menu_block display on the revision pages which I've created an issue for #2173749: Allow display of menu block on node revision pages

@azinck: This whole thing needs to be split in two: 1) a default configuration that allows the node revision to be displayed with the node_view handler, 2) a new node_revision handler for the small number of sites that want to display something differently.

So lets focus our efforts on #1820882: Make node revisions use the node_view display to cover the default use case, and this one to cover the optional customization for sites that need it.

Pushing this back to "needs work" as it shouldn't be trying to change the node_view handler.

Any update on this since last comment #30? I have tested the patches in this ticket as well as the one in #1820882: Make node revisions use the node_view display in the Ctools and Revisioning modules and my revision view path /node/%nid/revisions/%/view still displays the default "manage display" settings from the CT instead of displaying the custom Panels Page override of the /node/%nid display that I have in place for that CT. I tested on several types of CT's that I have a panels page manager custom display for.

hi
#15 works better for me too

thanks

@hershy.k

did you find solution ?

It seems to me that this is a near duplicate of #1820882: Make node revisions use the node_view display.

It seems the remaining task is #30: "2) a new node_revision handler for the small number of sites that want to display something differently."

... and that it hasn't been done yet. Could those who are interested please comment and, preferably, submit a patch?