Port Lightbox2 to Drupal 7

partial port, not functional AT ALL, just want to keep a reference point of where I was

got a lil more work done on this, it's actually calling *a* theming function now, but it's currently still using 1 single theming function and the JS doesn't seem to be getting run

I haven't touched any of the naming for functions like imagefield_image_imagecache_something because I was unsure on how to rename them (as both imagefield and imagecache are now image and image_image_image_something seems a bit silly)

I also haven't looked at the emfield (emvideo, emimage, ...) stuff, again, because I was unsure on how to handle it

hope this partial is already sort of useful, it was already sort of useful for me, but more in terms of getting down & dirty with field API

+1 subscribe

Now we have Drupal 7 Core alpha 5. Maybe next time Drupal core will be a beta version. Is there a 7.x dev version or alpha version of Lightbox2? I can test in a drupal 7 website and give feedback.

lightbox2 needs to go under a major rewrite, or possibly merged into the new starbox module.

hm, I didn't even know about starbox... but considering it's current status, do you think it's feasible to get that and this ready by release-day?

I'm not sure we'd do both, or even if we'd get starbox finished, but I think that's where efforts should be concentrated. We're still at the discussion/planning stage as we want to build it right from the start, rather than the organic mess that lightbox2 is.

subscribing

is there any news regarding the port / restart of lightbox2?

subscribing

Subscribing.

how is the StarBox module going on? Any update?

Subscribing

subscribing

Colorbox module already works now with D7 so maybe join forces?

Subscribing

subscribe

Subscribing.

Subscribe

subscribing

subscribing

subscribing

any news?

subscribing

Subscribing.

Subscribing.

subscr.

subscribing

subscribing. interesting in lightbox2 in d7

subscribing

subscribing

subscribing

I've got a dev version I can put up. It applies the above patches as well as a fix for the permissions.

Here guys let me know if this helps at all.

lightbox2 7-dev.zip is still very buggy, subscribing

subscribing

subscribing

subscribing

Colorbox doesn't even get near of what Lightbox2 was able to do in Drupal 6...

Colorbox needs too much configuration and doesn't work with images uploades through IMCE and used with any wysiwyg...

Subscribing

subscribe

subscribe

subscribe

subscribing

If this isn't getting anywhere, anyone know of a substitute?

Well, after trying how insert module works with colorbox module and watching the excellent FileField Insert / Image Resize Filter screencast by MustardSeed Media. we seem to have a good alternative, even though this means to install and configure three modules instead of only one...

Subscribing

Subscribing

Subscribing

subscribing.

javizcaino, very interesting post thank you.

@javizcaino

this one is cool too - http://drupal.org/project/wysiwyg_imagefield

@LPCA
Let me try that out... Thanks!

Subscribing

subscribing

subscribe

subscribing

subscribing

subscribe

Agreed. I'd sure love to see this module ported to D7.

I get the code at #34 and start to work on it:
https://github.com/yukare/lightbox
If someone else want to help, tell me and i add to github.

Edit: i made a small change and now links with rel="lightbox" are working, will look on another things. If you test the module and something goes wrong, please report here.

maybe a good idea to use https://github.com/fnagel/jQuery-Accessible-RIA/tree/master/Lightbox/ ?

My main target is to make a version for drupal 7 with the same as drupal 6.
This is the current status of the porting:

Works
* Add a image with rel="lightbox"
* Add a image group with rel="lightbox[group]"
* Slideshow using rel="lightshow[group]"
* HTML content using rel="lightframe"
* Modal with rel="lightmodal", and with settings

Do not work
* Title is not working anywere

Integration with external modules
* acidvideo - There is not a drupal 7 version
* I did not test the other modules if it works or if there is a drupal 7 version for it

Not tested
* Video using rel=lightshow - I need help with this, can someone provide a flvplayer.swf for me and a working example in drupal 6 version ?

To do
* Add a description in hook_permission
* There is many filters without any action, look if this is really necessaary,
if not, remove the ones without action

Update:
Title is now working, it was just a line to fix.
Commented some parts of code which is not ported to drupal 7 and cause warnings, thanks to mvdz2011 by reporting it.
This time i did a new zip file, it is better that get the code from git hub, please test and report any issue.
I still need help in testing the video.
The contact and user login modal window do not work, i will work on this and after on the modules integration.

subscribing.. thank you for your work

sub

sub

admin/config/user-interface/lightbox2/automatic: "Call to undefined function image_get_sizes() in modules/lightbox2/lightbox2.admin.inc on line 803"

But it works...

What about Flickr support ? I guess this is under the "Automatic image handling" tab.
Which throws the following error in my drupal installation:

Fatal error: Call to undefined function image_get_sizes() in ... \sites\all\modules\lightbox2\lightbox2.admin.inc on line 803

Image.module is now part of core, and no longer sports a get_image_sizes function. In fact from what I understand, the image.module in core is mostly a place where the Imagecache and ImageAPI modules have been folded into.

Perhaps it would be useful to comment out the

if (module_exists('image')) {
  ...
} 

statement, so that the users at least have access to the other settings for this tab.

Useful documentation for somebody attempting a patch may be:
- http://api.drupal.org/api/drupal/modules--image--image.module/function/i...
- http://api.lullabot.com/image_get_sizes
- http://drupal.org/node/513096 (The Future of Image in Drupal 7)

Listening.

subs +1

I get this kind of error:

An error occurred while attempting to process /system/ajax: iterator is undefined

subscribing

This is a important error which i am trying to solve.
I have seen a post about this error is caused about a call to theme() with variables instead of an associative array, i am looking at it.
A workarround is to disable the loading of lightbox in pages like admin/* node/*/edit and node/add, this can be done in configuration.

New version:
* fix the error at #72 which is very important, as it make all ajax requests do not work on the website (the fix was do not load any css and js code from lightbox when is an ajax request)
* replace user/login and contact with user/login/lightbox2 and contact/lightbox2 now working, login and contact can now be in a lightbox

Nothing from modules integration working yet :( but please keep reporting issues as done in #72 if you found one.

Thanks i'll take a look later!.

Nop, I still have some error.

In #overlay=admin/structure/types/manage/article/display/full Just can't select any lightbox options, and the ajax is broken.

subscribing

I've simply imported Lightbox2 JS and CSS in my D7 project (no module).
It works perfectly but with Google Analytics Module activated..
So there is something wrong between lightbox and GA module

I think it's an old known issue, but I write here for future memory ;)

I have a question regarding the 'Automatic image handling' page of the configuration, should this handle flickr images and photosets from the flickr module?

subscribing

subscribing

subscribe

subscribe

This module as it is has some big ajax incompatibilities with the latest dev of Views 3.

It could not find any of the js files (all js files under http://drupal7/sites/all/modules/lightbox2/js/ )

and gave tons of Ajax errors.

I am sure you know this, but just in case.

subscribe

subscribe

Subscribe

Using zip from #75 I cannot get rel=lightvideo to work with a simple YouTube link. Has anyone else gotten this to work? Thanks!

subscribe

subscribe

subscribe

subscribe

subscribe

Can the current .zip be added to the drupal repository so we have a 7.x-1.x-dev Development Release listed on the lightbox2 page?

Thanks!

subscribe

subscribe

subscribe

+1

+1

+1

subscribe

+1

+1

subscribing.

+1

subscribing

subscribing

subscribing

subscribing

+1

When I trying to upload image I receive this error - "An error occurred while attempting to process /file/ajax/field_image/und/0/form-pzyILwQtiVN79g6R96_QAlfChAxx7k3pOILhlhcVxvU : Cannot call method 'bind' of undefined" and can't upload any files. When I disable lightbox2 module than upload work correct. How to fix this?

I found that this error caused by conflict with my jQuery carousel at other page... so I was comment in lightbox2.module line drupal_add_js($path .'/js/prototype.js', array( 'scope' => $js_location ) ); and now all ok.

Can the current .zip be added to the drupal repository so we have a 7.x-1.x-dev Development Release listed on the lightbox2 page?

Why hasn't this happened yet?

I have requested to be a co-maintener of the module, see http://drupal.org/node/1164156, when i get git access i will commit the code, make a dev release, and keep working to make everything that works on d6 work on d7.

+1

subscribing

subscribing

+1

+1

+1

+1

+1

Subscribed.

+1

yukare, apparently stella granted you co-maintainer status back on May 23, 2011 at 7:37pm. What's going on?

subscribing

+1

subscribing (oh please please please please please port to D7 dev!)

Subscribing

I've created a git patch from the current git 7.x branch to the version yukare posted (#75). I've tested the lightframe filter and it works as expected.

Thank's yukare and all the coders that have contributed here for the great work done.

Please some mantainer commit this, because right now it's hard to know where to get the last D7 version and it's much better to have git repository updated.

sub

I also keep getting the error messages "An error occurred while attempting to process /system/ajax: iterator is undefined" in different admin and user modules. I have to disable the lightbox2 plugin module to do administrative tasks, then re-enable lightbox2, but I am setting up Drupal Commerce and some of the functions that users need are getting the same "An error occurred while attempting to process /system/ajax: iterator is undefined" error messages... somehow the included files in lightbox2 are conflicting with a lot of other modules ajax.

if the error occurred after applying the patch in #132, this remains a task, but just shows it still needs work.

if the error occurred in the 6.x-dev branch, please file a separate issue.

reverting status.

I just make some changes to drupal 7 version on 7. I think this changes was on my previous commit, but it was not(I lost to git), but now the version on 7.x branch is working, is the same as #75 with some minor improvements, please test it and report anything.

Is there a Dev version to try out?

You can get it direct from git using:

git clone --branch 7.x-1.x http://git.drupal.org/project/lightbox2.git

Per #138 Sorry but i get The requested URL /project/lightbox2.git was not found on this server.

#139 I've checked it and it works.

But you used it with git?
This a line to use in a terminal like bash, it will get the files using the git program, it is not to open the url in a web browser. I have attached a .tar.gz package to this comment with it, but try always use the git version, as it will me more updated.

After testing, I noticed that there are no lightbox2 display settings on any image fields on nodes also getting same error as #134

I do not have this error, so please help me finding it.
If you can, disable all other modules, like a simple drupal install, and enable one at a time until you have the error, and tell me what module causes this, i will try to fix it.
I have it working at my site, just look this address http://www.jaguaribe.net/drupal/modulos/lightbox2, there is some links with samples how to use lightbox(the page is in Portuguese) but the important is that i do not have the error, so:

1. Remove the folder with lightbox2 that you have now
2. Get it from git(just to make sure you have the last version and not an older)
3. Disable one module at a time until you do not have the error, tell me the name of the module, the url where you have the error, and what you are doing when you have the error.

Current i did not worked on image field, but i will do it now, but the error is not related to this, i think.
Thanks for repporting it.

I have done a basic install of drupal and the latest git version of lightbox2 and I am still seeing the error.

Steps to reproduce:

1) Install Drupal 7 (Standard Install, not Minimal)
2) Enable Lightbox2
3) go to admin/structure/types/manage/article/display
4) No Lightbox2 Selection in Format Settings
5) Clicking on Settings Gear produces "An error occurred while attempting to process /system/ajax: iterator is undefined"

See screenshot attached

Subscribing

I get same error as #144; also cannot edit Panel Content with Lightbox2 enabled, see image below.

any chance of someone posting a dev version on the project page, so we can encourage more testing? :)

Subscribing

#144 and 146:
I am sorry, but i was not able to fix this error, just loading the file prototype.js gives the error, I tried other versions of prototype and get another errors :(

Just as workarround, you can disable the loading of ligthbox in admin/config/user-interface/lightbox2/general in the pages that you do not want it like admin/*

#147
I do not have permission to do this, maybe only stella can do it, but i think that we must fix the previous error before this, as it breaks some parts of a drupal site(ajax and table drag/drop as example)

Please test this before i commit it, at last it works for me.
On lightbox2.module, on the line 785:
drupal_add_js($path .'/js/prototype.js', array( 'scope' => $js_location ) );

Comment or delete the line. This will make the file do not load, but lightbox still works.

I can confirm that removing line 785 does remove the error, however, there are no display settings for content types to use lightbox.

I will work in image support, but i never used it in drupal 6, so i do not know what it does to test.
Can you tell me what you want to do with it? Like add many images and view as slideshow?

just looking to change the display setting on, say the article content type, from thumbnail to lightbox=thumbnail. Just like it did in D6. See screenshots for comparison.

I just push 3 changes to git:
1. Do not try to load unused files from scripticalus, this remove a lots of messages in watchdog.
2. Do not load prototype.js, remove the error at #144 and #146
3. Remove some comments and small change, image field is working.

Please, this really more testing, as i just make it work, but some real use cases will be good.

Since i can not create a dev release and not everyone likes git, i am posting a .tar.gz file with latest git version.

About emfield:
There is not a version of emfield for Drupal 7 and will not have one. The recommended module is media in Drupal 7, so i will work on it, but i do not promisse anything soon.
I will comment/remove all references to emfield in lightbox because of this.

With the latest git version, I'm now getting an error on install

Notice: Undefined index: presetname in lightbox2_theme() (line 1053 of /sites/all/modules/lightbox2/lightbox2.module).

I found this too.
On lightbox2.module, add this line on 1048:

$src['presetname'] = '';

Important: this is not a fix, and will not be commited, is just a simple hack to remove the warnings, as they will be on watchdog too.

The bug:
$src['presetname'] is available from the function image_styles() in drupal 6, but not in drupal 7, so i have to found what it means in drupal 6 and what is the replacement in drupal 7.

Works perfectly now. Everything, other than the issue in #156-157, is working as expected. Well done @yukare !

subscribe

Commit the fix for #156 - #157 at http://drupal.org/commitlog/commit/1470/856e22df24898bc1a383be4f6f75b109...

For me, the only issue missing is #155, if there is any other task please report it. We really need more testing before making a release, I already talk to stella and she will do it soon(or i hope).

Hi:

I don't know if this could be useful to solve #155 (support media module):
In colorbox there's an issue discussing media/styles integration (styles is not a dependency of media anymore so I think we can focus on media alone by now). This is the Issue #1079804: Media/Styles modules support?
In #3 of that issue kmadel talks about a module that integrates colorbox and media module to some extent: http://drupal.org/sandbox/kmadel/1084984
I've tried it and works fine. Perhaps you read this module to get inspired...

Thanks for your work!

Possible bug with js agregation:
I need that someone test this to see if it is not only on my site. If i enable js agregation i have some javascript troubles on my site, in admim menu/ckeditor/lightbox 2, so i have made this change, on lighbox2.module

	drupal_add_js($path .'/js/scriptaculous.js', array( 'scope' => $js_location ) );
	drupal_add_js($path .'/js/lightbox.js', array( 'scope' => $js_location ) );

Replace it with:

	drupal_add_js($path .'/js/scriptaculous.js', array( 'scope' => $js_location, 'cache' => false ) );
	drupal_add_js($path .'/js/lightbox.js', array( 'scope' => $js_location ,'cache' => false) );

It is not a real fix, but it remove lighbox2 from js agregation and everything works again.

For D7 the proper way use hook_library() for examples take a look at core's JS libraries system_library() or http://drupal.org/project/examples

subscribe

Why is there still no "dev" version link on the main Lightbox2 page? The only way people know that there is even any work being done on LightBox2 is to look at this bug list. Is there a zip version anywhere so you can use the D7 install module function? If not, how do you download and install whatever version is available for download? Despite being a programmer in other languages (Delphi, Visual C#, Visual Basic) and using Subversion, I really don't want to download or learn and take up space on my hard drive with yet another application, Git, just to install software that doesn't have an installer yet or the occasional patch (that should also have a better way to apply than using a version control system).

I am working on the lightbox, but i do not have the privilegies on drupal.org for creating a dev version of lightbox, so i can not make it. I have send a message to stella 10 days ago and she tell me that she was on holidays and can not do it until this weekend.
I will just wait more few days before sending another message to her.
You can use the zip in this comment, is the same content as in git server, but have the change #162 which i do not commited because none else have this problem. I know that is not simple to get the files from git, but if you see my previous comments, i have done many zip files like this one.

subscribe

subscribe

Thank you! I will give this a try. And I'm not blaming you. You didn't decide on a version control system being the method of handling dev releases and patching. I think sometimes people who are programmers lose site of the fact that a lot of admins are NOT programmers, so it makes it impossible for them to look at new features until there is a released version. I hope in the future there is a more end-user friendly system for handling updates as changed get added. My other off-topic gripe is that the user interface isn't "drag and drop" for adjusting your theme/blocks/regions. It is more just "rearrange items in a list". To me, drag and drop means WYSIWYG. You could be able to grab a block and drop it into a region visually while looking at your page. But like I said, that's off topic :)

heh, there is no version tagged for release, not even dev, hence there is no package on the project page
this is not a problem with the system (git or project.module & family) but with the fact that no release tags were found
if clicking a tar.gz is a programmer thing, all hope truly is lost for this world

nothing prevents you from building this awesome system of yours, but please, stop poisoning this already cruft-filled issue with more unrelated ranting, the relentless downpouring of essentially worthless "subscribe" posts are bad enough, thank you.

But it is ok for you to do what you just told me not to, right? ;) Not sure what you are talking about here. There is no tar.gz or zip for a version 7, so no way to download it. So only a programmer would be able to use Git or whatever to find where these releases live and "check out" the code. I was speaking though of how before a new release is available, there is often a weeks or months long system of finding patches hidden in the bugs section (here). Having to use Git or whatever to patch code is not a user friendly system. I know the volunteers do not always have time to build a tar/zip each time, or have access to upload it. Rather than gripe, I'm happy to help by volunteering to help update the changes to an install file for anyone.

You can actually find a snapshot (tar.gz) on drupalcode.org. From the project page, follow the link 'Repository viewer', click the head version (7.x-1.x), tree, snapshot.
http://drupalcode.org/project/lightbox2.git/tree/refs/heads/7.x-1.x.

I'm sorry for my futile attempts to inform you. You are right, we should definitely abandon any type of versioning system and just FTP some zip files. This will most likely cause a serious boom in the development of Drupal core and modules.

Obviously, this is the perfect issue to discuss these much-needed changes, as this will go in the most relevant queue.

I'm even more sorry for posting the patch that got this issue rolling in the first place, as I now have no way to abandon this issue altogether. But that's not a system you're having problems with, so let's not discuss that in this issue...

However, I'll be glad to give you a personal course in copy/pasting a single line, be sure to get in touch if you're interested!

Unsubscribe..

..oh, it doesn't work :(

Obviously English is not your first language, so you are having trouble understanding what I am trying to say and instead go off on a troll tangent about something completely different than my point, which I believe I explained clearly. Its not worth spending time trying to explain it to you. I can see from your other posts what kind of individual you are, so there is no need to have further contact with you. Thanks to the rest of you for your help! Glad to have Lightbox2 on D7 now!

He was referring to the fact that nightly builds and commits aren't readily available to the end-user as he liked and was interested in the latest release; if I'm reading that correctly. You don't have to jump down his throat and go on your own little rant about some nonsense. Get off your high horse; you might have contributed your part to the project, but that doesn't give you the right to immediately flame users with frivolous snark.

Thanks to everyone for the updates!

heh, I guess I still wasn't clear enough, but I have taken the liberty to voice your complains in the related queue (or at least one that isn't ridiculously unrelated) -> #1221872: Provide an easier way to download a package of the current HEAD

Please try to keep further comments regarding that issue, in that issue, and comments regarding this issue, in this issue.

Thank you!

subscribe

Hey guys,

Shadowbox is quite powerful for D7 and in conjunction with our new module even more powerful:
http://drupal.org/project/media_embedded

sub

I make a dev version now, it may take some time do show on the project page(12 hours i think) and i will do some work today and release an alpha version soon. Stella wants to review the module before realeasing a more stable version.

So I have i request for everyone there, please test the dev version and report anything that is wrong/missing from Drupal 6, and please, open new issues for version 7.x-1.x-dev so is easy to work than search for things than looking at 180+ comments here.

I have no CCK display settings with the current version of Lightbox2. This is frustrating because it prevents me from grouping by field name and effectively prevents me from easily creating photo galleries.

Then to comment out and a line 786 :)

Then to comment out and a line 786

Could we pls. close this issue? There IS a 7.x-dev. release out, and bugs related it, should be reported as new issues. Install, test, break it and remember to post new issues with your findings to provide the dev. the much needed feedback.