Hi,

Don't know if same sort of problem as: http://drupal.org/node/672096, but my Meta Tags on a "other page" are also not saved. I think it goes to NODEWORDS_TYPE_NONE instead of to another for "other pages".

Thanks for going into this!
Greetings, Mattijn

Files: 
CommentFileSizeAuthor
#25 nodewords_6.x-1.11_page_fix.diff908 byteshaagendazs
PASSED: [[SimpleTest]]: [MySQL] 277 pass(es).
[ View ]
#15 fix.diff436 bytesLars Pohlmann
PASSED: [[SimpleTest]]: [MySQL] 277 pass(es).
[ View ]

Comments

It sometimes also goes to NODEWORDS_TYPE_ERRORPAGE I think..but how can this be possible, is the path than not found?
Greetings, Martijn

Hi,
It looks like it goes wrong on: function nodewords_get_tags($type, $ids = array(0), $options = array())
And on this part of the code:

    // Prepare the tags.
    foreach (nodewords_get_possible_tags() as $name => $info) {
      // Filter out tags the user has chosen not to see
      if ($options['filter'] && empty($head_tags[$name])) {
        continue;
      }

It looks like for "other pages" all meta tags are filtered out. Again, I am just a amateur, so please investigate yourself also.
Thanks for going into this.
greetings,
Martijn

Title:Other pages Meta Tags not saved alsoMeta tags for "other pages" are not used
Status:Active» Fixed

The meta tags values for other pages are saved; the problem is that they are not found.

I changed the code, and committed it in CVS.
Thanks for your report.

I have marked #691338: adding meta tags to 'other pages' not working as duplicate of this report.

Does the -dev version ( 6.x-1.x-dev: 2010-Jan-22) contain the fix?

EDIT: no, the 2010-Jan-23 does contain it :-)

It looks that latest -dev version doesn't prints meta tags on the home page either, not only the tags configured for custom pages :-(

EDIT: with the -dev version released 23th jan, the home page problem disappeared

Marked #690194: Nodewords and Views 2 as duplicate of this report.

subscribed

I'm having the same issue using the same version.

No descriptions nor keywords are saved when I save "other pages."

Not only are they not displaying on the path I supply, but when I click "edit" in the operations column of admin/content/nodewords/meta-tags/other, the form loads with empty fields.

I'm looking at the CVS and I don't see any mention of this, maybe I'm just blind, but what can I do to resolve this?

any chance of getting a patch to fix this in 6.x-1.11 as i'm having trouble with the current dev snapshot

@locomo: The development snapshot should be used just for test; you should not use it in a production site because updating from development snapshot to development snapshot of the same branch is not supported.

thanks kiamlaluno .. that's why i was asking for a patch to fix this issue in 6.x-1.11 .. or i am i confused.. my understanding from the thread above was that this issue was corrected but only in the latest dev version.. i'm using 6.x-1.11 and i'd really like to get this corrected

or if you could direct me to the location in the code where you made the fix maybe i'm can figure it out

thanks

StatusFileSize
new436 bytes
PASSED: [[SimpleTest]]: [MySQL] 277 pass(es).
[ View ]

Here is a patch, that works for me.

Status:Fixed» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

I used this patch on 6.x-1.11 and meta tags still aren't displayed for "Other Pages" for me

Status:Needs work» Reviewed & tested by the community

I tested on the patch on 6.x-1.11 as well. Works fine for me. All tags are retrieved properly after the patch has been applied.

I applied the patch and it sorta worked. The description text is being saved but it is not being displayed in the HTML of the view page.

Is displaying in the page, not the purpose of meta tags... greetings, Martijn

I am having the same issue described above. After applying the patch, the keywords are saved, but they do not display on the page that they are supposed to.

I mean, it is march now. Is this ever going to be fixed? tags not showing on the page is really bad.

StatusFileSize
new908 bytes
PASSED: [[SimpleTest]]: [MySQL] 277 pass(es).
[ View ]

@Lars Pohlmann: Thanks for creating the initial patch. I tried it out and it worked for me, but not completely. With your patch, only the data from the first custom page showed up, but for all pages.
I revised the patch, this version fixed the bug with custom pages for me completely.

Status:Reviewed & tested by the community» Fixed

The patch reported by Daniel is the correct one, and it is how the code has been changed.

As usual, read what reported in the project page, before to update the installed modules.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status:Closed (fixed)» Fixed

I have marked #778584: Unable to save meta tags for 'Other pages' as duplicate of this report.

I am having a similiar issue and was wondering what release we should be grabbing (beta9?) to get this fix. Or do we need to apply this ourselves?

Status:Fixed» Active

Can someone please throw us a bone? so we know which version to deploy.

Hi,
look at the remarks at the homepage. I myself are using version 1.11. If it doesn't work, go back to 1.9.
1.12 and further is not finished yet. 3.x is integrated in 1.12 beta releases is what I am reading.
Alberto is bizzy with this is my latest information.

greetings, Martijn

I have marked #788704: Meta Tags in Custom Page disappearing as duplicate of this report.

subscribed

I applied Daniel's patch (Thank you!) and the description text is being saved but it is not being displayed in the HTML of the view page.

Are there any other suggestions to fix this issue? Thanks!

Status:Active» Fixed

As I already reported, the patch reported by Daniel is how the code has been already changed (the changed code does not match with Daniel's patch because the function has been named differently).

Please don't re-open an issue report for an already fixed issue only because you don't understand which module version to use; marking it back to active just confuse users who can think the issue has not been fixed in any version after version 6.x-1.11, which is not true. Changing the status to active when a problem has been fixed forces me to re-read all the left comments when I could take that time to resolve other issues that have been reported.

I have marked #791508: Nodewords Custom Page as duplicate of this report.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Kiam
You say that the problem is solved but still nobody said which version should be used and which is one safe.

Is 1.11 plus the Daniel's patch correct and safe for the production sites?
Or I should use one of 1.12.betas?

@barteque: applying the #25 patch of Daniel Hanold (aka haagendazs) works fine if you use Nodewords 6.x-1.11 on Drupal 6.19, which is what I just did seconds ago.

I just tried that. Applied the patch from #25 to 1.11 on 6.19 and the tags for "other" pages ARE now being saved... but they're still not being used.
??????
Drat!

Status:Closed (fixed)» Postponed (maintainer needs more info)
Issue tags:+v6.x-1.12 blocker

If anyone is still having problems with this functionality, please try the latest v6.x-1.x-dev snapshot and report back if the problem still exists.

OK, will do.
THX

FWIW: I notice, after adding the aforementioned patch, that although the "keyword" and "description" values are now being saved, the "enabled" button value will still not "stick." Maybe that's the problem.

Will try the latest dev and get back to you.

PS: Did I mention this is a great module?
(Albeit, a bit "stubborn" at the moment.)

Whoa!
I "dropped" it in (without updating my database) and noticed meta tags were all gone.
Taking a closer look, I see this dev snapshot is a major overhaul--all new sub-modules/paths.

I backed up my db this morning, but since this is a production site, I really don't want to mess anything up.

Does this dev version make any database table/field changes from 1.11?

That is, is it safe to run "update.php?" Or could this turn into a real headache?
Everything is running "well-enough" without meta tags on these three views pages.

Glad you have a backup =)

Yes, there are some schema changes from v6.x-1.11 to v6.x-1.1x-dev.

I have backups of my backups.
;-)
OK, I took the plunge and all is still there.
:)
I like the new admin interface... much more intuitive.

Unfortunately, now I have no meta tags on my Views ("other") pages whereas before it was plugging in the defaults.

The "enabled" radio-button-value still will not stick here: /admin/content/nodewords/custom/3/edit
I click "enabled," but when I come back to it, it's not checked anymore.
:(
It SAYS it's enabled here: /admin/content/nodewords/custom but not here: /admin/content/nodewords/custom/3/edit ... which might explain a lot (or it might not).

The good news is... the other pages are still good, it's just these three Views pages that won't take tags. Which is fine because "before" I was adding meta tags to Views pages in "page.tpl.php" (based on $_SERVER['REQUEST_URI']) and then Nodewords was adding the default tags, resulting in duplicates.
So... I can live with this fine.

Thanks for the GREAT module, and good luck ironing out these details.
:-)

Status:Postponed (maintainer needs more info)» Needs review

I'm changing this to Needs Review so that either Dave or I can give it a good testing.

Status:Needs review» Fixed

Custom page meta tags works just fine for me using the latest 6.x-1.x-dev code. I feel confident marking this as fixed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

issue exists.

#25

Fixed robots not being displayed on views pages