I don't want to use suckerfish for my primary menu. Is there a way to remove the suckerfish from the subtheme without overriding the core theme?

Thanks.

Comments

stephthegeek’s picture

Good timing... a theme setting to disable the dropdown is already implemented and will be in the next release coming asap

sociotech’s picture

Status: Active » Fixed

This is now a theme setting (under the Navigation fieldset) in the latest beta 4 release.

ManyNancy’s picture

Thanks a lot.

ManyNancy’s picture

Version: 6.x-1.0-beta3 » 6.x-1.0-beta4
Status: Fixed » Active

By disabling the dropdown all the submenu items are not rendered. Is this normal drupal behavior? I was planning on implementing my own dropdown behavior on the primary menu. I guess I can't use the primary menu to with my own drop down menu?

stephthegeek’s picture

Status: Active » Postponed (maintainer needs more info)

I'm not sure I understand the question. If they're not in the dropdown, where would they be rendered? :)

But yes, if you want to do your own dropdown structure, you'll need to re-add them on your own. I'm curious why you're doing this? There are ways to use the other Superfish menu styles in your subtheme, or completely differently theme the look of it so we'd be happy to point you at that if that's the issue, or if you have any suggestions to make it better suit your needs.

ManyNancy’s picture

Status: Postponed (maintainer needs more info) » Active

Shouldn't it be rendered as a normal drupal menu, as if it was a block put into a region?

I don't want to use the suckerfish dropdown, I have my own oh so special menu.

My suggestion is for the sub menu items to be rendered normally, so that they can be themed. I assume if any user doesn't want any sub menu items they wouldn't include sub menus in the first place.

I don't need the structure to be different, just the regular structure minus suckerfish. That would be really nice, thanks.

stephthegeek’s picture

Status: Active » Fixed

Shouldn't it be rendered as a normal drupal menu, as if it was a block put into a region? No. Primary and secondary links in Drupal are special and don't have the same output as blocks regardless. But we're doing even more with theming of the output in order to do the dropdowns. There's not really a way to make them "there" yet not mess up the display. If you need the sub-items output for styling, you can just use the primary links block in a region, or I would give the menu block module a try to just put the sub-items elsewhere: http://drupal.org/project/menu_block

Again I'd love to know what you're doing with it so we can better understand what isn't possible with the current output.

Thanks!

ManyNancy’s picture

Even though it's deactivated and primary menu turned off, suckerfish js is still loaded unnecessarily.

ManyNancy’s picture

Status: Fixed » Active
sociotech’s picture

Status: Active » Fixed

ManyNancy,

We don't currently have the Skinr functionality (page level settings) that would allow us to disable the Superfish js.

In the meantime, if you really want to remove the js (and css) you can comment out the following declarations in the fusion_core.info file in your fusion_core directory:

stylesheets[all][] = css/superfish.css
stylesheets[all][] = css/superfish-navbar.css
stylesheets[all][] = css/superfish-vertical.css

scripts[] = js/jquery.bgiframe.min.js
scripts[] = js/hoverIntent.js
scripts[] = js/supposition.js
scripts[] = js/supersubs.js
scripts[] = js/superfish.js

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ManyNancy’s picture

Will this feature be implemented at any point? Because changing core is something really bad.

jsibley’s picture

Version: 6.x-1.0-beta4 » 6.x-1.0

I am having a similar issue. I want use use the superfish module, for its added functionality. With some css changes, i've got it working, but the superfish js filesnloaded by fusion are getting in the way of the other superfish js files used by the module.

Is there any reason for the theme to load the superfish js files if dropdown menus arent enabled? It would be nice not to have to change the info file.

mattcasey’s picture

StatusFileSize
new1.47 KB

My solution: this patch only loads the following javascript files if Superfish has been enabled, saving 12KB: hoverIntent.js, superfish.js, supersubs.js, and supposition.js.

mattcasey’s picture

Status: Closed (fixed) » Needs review

Status: Needs review » Needs work

The last submitted patch, dontalwaysloadsuperfishjs-680774-13.patch, failed testing.

mattcasey’s picture

I'm not sure why the test failed - I used the commands from the module's Version Control page to get 6.x-1.x. Was also able to re-download and apply the patch on my system (Windows). I've uploaded patches before but this is the first time Drupal.org decided to test one!

mattcasey’s picture

StatusFileSize
new3.32 KB

Update to patch: check if $.superfish() exists in script.js

esmerel’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, dontalwaysloadsuperfishjs-687704-18.patch, failed testing.

Poieo’s picture

Issue summary: View changes
Status: Needs work » Closed (won't fix)

Closing as won't fix since the D6 version is not getting any new development.