Closed (fixed)
Project:
MP3 Player
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2010 at 17:42 UTC
Updated:
12 Jun 2014 at 06:22 UTC
Jump to comment: Most recent
Martin Barbella reported the following issues:
The name of the mp3 file is not properly sanitized when the javascript
to create the audio player is generated, resulting in a cross site
scripting vulnerability.
The module also fails to sanitize various inputs on the MP3 player
administration page. In the cases where the user is prompted for 6
digit hex values to use as colors for the player, it will only check
that the value is 6 characters long, and will not verify that it is
hexadecimal, but as this is both difficult to exploit, and requires
that the user can administer the MP3 player module, the rest of this
report will only focus on the previous vulnerability.
As the module has no releases, this can be solved in public.
NOTE: we were so far unable to reproduce the filename issue.
Comments
Comment #1
markie commentedIn future release, the XSS issue is addressed in the output. See patch in https://drupal.org/node/2050425
Comment #2
markie commentedNew branch created 6.x-2.x
Comment #3
markie commentedkilling all 6.x-1.x issues cause they are not applicable.