Closed (fixed)
Project:
Fusion
Version:
6.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Mar 2010 at 01:35 UTC
Updated:
29 May 2011 at 09:32 UTC
Jump to comment: Most recent file
Sometimes the top part of the page is obscured (see screenshots).
First screenshot is of Acquia Prosper. Browser is Firefox 3.6 on Mac. Page is a comment-reply page - /comment/reply/3372#comment-form
Second screenshot is Fusion Starter showing same issue - title is completely obscured.
Third attachment is source code from second screenshot, showing title is present, so probably CSS issue?
Third screenshot is comparison of same site/same url as (2), using garland
issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | chrome.png | 60.13 KB | tsi |
| #1 | source of screenshot 2.png | 16.72 KB | lyricnz |
| Reply to comment Garland.png | 80.16 KB | lyricnz | |
| Source of http___localhost_motogpod_comment_reply_3372#comment-form.png | 16.72 KB | lyricnz | |
| Reply to comment | MotoGPod.png | 57.94 KB | lyricnz |
Comments
Comment #1
lyricnz commentedHeheh, d.o didn't like the filename of third attachment - here it is again.
Comment #2
jeremycaldwell commentedThanks lyricnz, this issue has come up before and is quite rare in our testings. We'll look into this a bit more and see what might be causing things. Thank you for the screenshots too, very helpful.
Comment #3
trevorleenc commentedI have also run into this intermittently, I'll keep a closer eye on it and report back the conditions under which it happens.
Comment #4
isopharius commentedsame issue on my website http://tactiqc.com/ using chrome browser
any link to a specific comment will truncate the top of the node, use the rightside block for example
Opera, Firefox, Kmeleon work right
Comment #5
tsi commentedI noticed the same issue when navigating to a comment url on my site, as in http://www.rtl-themes.co.il/content/ערכת-הבסיס-המושלמת#comment-32 at first I guessed it was an RTL issue (stranger things has happned), but then I noticed it was happening on your site too, see attached screenshot.
Happened with Chromium/Linux and Google chrome/Win XP.
Comment #6
jeremycaldwell commentedFor those having issues with the titles not displaying properly can you please try adding this bit of CSS to your "local.css" file in your theme's /css directory?
I'm not sure if that will fix it but it is worth a try. Thanks!
Comment #9
tsi commentedI think the issue tiltle here is a bit confusing, this is not really about the titles, this is what visibly happen but actually it's the
#maindiv that is being chopped, so the last post about h1 will not help here.IMO it is caused by the
clearfixgiven to#main-inner, deleting it in chrome fixes the issue (might be causing others though, I didn't noticed any)Comment #10
jeremycaldwell commentedThat sounds like it could be the issue for sure. I wish I could replicate this but I haven't been able to get my content cut off on any of my local development so would you mind removing the clearfix from that div and giving it a try on your site? That'd be great if we can get this issue nailed down as a few people have reported it and can see it consistently but I'm just not able to replicate it for some reason..
Comment #11
lyricnz commentedTSI: agree that the ultimate cause may be #main being chopped, but this issue was raised against a user-observable symptom, rather than the root cause. How's this?
Comment #12
tsi commented@lyricnz - that's better, I would put "main div is chopped on #comment paths" but it doesn't really matter.
@eternalistic - how come you can't replicate the issue ? just fire up chrome/chromium and press here.
Some testing results - the problematic
clearfixis not on#main(there is none) but on#main-inner, removing it had some effect (a few more visible pixels) but not enough, I had to also removeclearfixfrom#main-group-inner,#main-group-inner,#main-content-inner,#content-group-innerand#content-region-inner.At this point I can see the hole title but
#content-group-inneris still chopped in a way that the rounded corners (.corner-top) are still hidden.What are the implications/side-effects of removing
clearfixfrom all those divs ?BTW, Tendu has a similar issue
Comment #13
sociotech commentedlyricnz, TSI,
I've been looking into this issue extensively and think I've finally found a potential fix. The issue seems to be extra spacing that can be introduced with the css in the standard clearfix solution combined with webkit browsers that have a possible bug in handling that spacing with an anchor link (e.g., a comment link).
In the latest 6.x-1.x-dev version (dated 2010-Apr-24 or later) I've modified the clearfix method to further reduce possible extra spacing by setting the line-height:0 and overflow:auto for the clearfix:after element.
(Another solution would be to remove overflow:hidden for rows and blocks, but that's a pretty major change that could have unforseen effects for existing subthemes that use Fusion, so I'd rather not force that on folks. That said, I'm going to see if we can go that route in our D7 version of Fusion.)
So, could you try the 6.x-1.x-dev version and let me know if it resolves the issue of node titles being cut off?
Thanks for your assistance.
Comment #14
isopharius commentedissue seems to be fixed with latest -dev
thank you
Comment #15
stephthegeek commentedGreat, thanks for the report! Marking this fixed and will go in the next full release.
Comment #16
gmclelland commentedfix worked for me too
Comment #17
a5342346 commentedfyi, using latest 6.x-1.x-dev, i'm seeing this in GoogleChrome vs, e.g., Firefox
http://img412.imageshack.us/img412/27/chromequirk.png
suggested in #irc that it's the same issue ... if so, then unresolved.
Comment #18
sjtout commentedsubscribing
Comment #19
tsi commentedaccording to #17 this is not fixed
Comment #20
sociotech commentedBenDJ,
I'm not able to reproduce the cut-off effect in your image. Can you provide more information about which pages this occurs on, what kind of region layout you have, what subtheme you're using, what modifications (if any) you've made to the css, etc.
Thanks
Comment #21
a5342346 commented> Can you provide more information about which pages this occurs on
seemingly, any page with a heading. here's a 'simple' "about" page -> http://tinyurl.com/33mu7gr
note the difference in both the menubar items' positioning, as well as the top-cropping of the "About" header text
> what kind of region layout you have
I'm not clear what you're asking here. In the example above, the two affected regions are a menubar and a one-column body ...
> what subtheme you're using
It's a customized fusion_starter subtheme,
drush pm-list | grep -i fusion
Other Fusion Core (fusion_core) Theme Enabled 6.x-1.x-dev
Other Fusion Starter (fusion_starter) Theme Disabled 6.x-1.x-dev
Other Fusion Starter Lite (fusion_starter_lite) Theme Disabled 6.x-1.x-dev
Other BenDJ Fusion (bendj_fusion) Theme Enabled 6.x-1.x-dev
> what modifications (if any) you've made to the css, etc.
plenty, of course. short of zipping up my site -- what is it specifically you're looking for?
Comment #22
lyricnz commentedBenDJ: can you reproduce this problem with the unmodified starter theme?
Comment #23
a5342346 commentedlyricnz: switched, per suggestion, to unmodified starter theme. of course, virtually everything's missing from the displayed page ... BUT, the "About" header, which *does* show up, is NOT cropped in the GoogleChrome instance.
which suggests something in my subtheme styling or region usage has 'hit' a GoogleChrome quirk.
I've checked as many browsers as I can get my hands on, and -- so far -- it's only GoogleChrome that displays the cropping, as described above.
Oh, and of course, IE6 is its usual nightmare ... but I'm not going to worry abt _it_.
Still trying to narrow down what the problem might be ... I've been "single stepping" through various options in Chrome's Firebug-esque developer tools. So far, haven't stumbled on the cause.
Comment #24
a5342346 commentedComment #25
sociotech commentedComment #26
a5342346 commentedbug report » support request
??
Comment #27
stephthegeek commentedBen, it doesn't need to be marked "won't fix", but since you said the issue was in your custom subtheme then it's no longer a bug report for Fusion itself, but a support request for your particular case. I believe the original issue is actually fixed here.
If that's not the case, can you elaborate?
Comment #28
sociotech commentedBug fixed in 6.x-1.0 release.
If there is still a related support request, a new issue should be opened.
Comment #29
a5342346 commentedlyricnz, just fyi as it's "your" bug ...
worksforsome, i suppose. just not here.
http://img208.imageshack.us/img208/5448/chromex.png
grep Id sites/all/themes/fusion/fusion_core/fusion_core.info
; $Id: fusion_core.info,v 1.1.2.9 2010/07/04 01:48:17 sociotech Exp $
rpm -qa | grep -i chrome
google-chrome-unstable-6.0.458.1-51742.x86_64
fwiw, no problems with any other browser. no problems with any non-fusion (sub)theme.
Comment #30
stephthegeek commentedBenDJ, the screenshot you've linked shows that you've got some custom typography in your subtheme, which may mean you need to adjust line heights further. This fix in Fusion is really only a workaround for what is actually a Chrome bug, and will only work so far, depending on the line height of your titles.
Comment #33
dddbbb commentedSorry to dig this one back up but...
I can replicate this title chopping bug in Firefox & Chrome with Panels. If you add comments to a panel page, clicking on a comment title will chop the top off of the page title (h1 title).
Trying the same thing without Panels doesn't produce the same results (works as expected). I'm using a Fusion sub theme with no custom CSS.
I know that bringing Panels into this is getting a little complex - wasn't sure whether to post here or over at Panels issues (I'm guessing it's something to do with all the extra markup that Panels brings to the party).
I didn't change the issue status - I'm fairly new to this and got told off last time :)
Comment #34
dddbbb commentedAdding the following CSS to local.css seems to fix it but does have abvious consequences:
Comment #35
jeremycaldwell commented@dixhuit, have you tried adding this bit of CSS to your theme's local.css file?
If not, give that a try and is should fix things for you. You can then remove the "h1.title" padding-top you are using now.
Comment #36
dddbbb commentedThat did it (#35). Thanks very much!
Comment #37
jeremycaldwell commentedVery cool, sometimes you need to use this fix/hack to get things working correctly in your theme. Not all themes are affected by this so apply only as needed. Glad I could help.
Comment #38
jenyum commentedJust encountered the same thing, and
on the .title element did the trick.
Comment #39
lolandese commentedSome blocks weren't visible but only on Mozilla Firefox (both 3.6 and 4.0).
#35 messed some things up. #38 wasn't effective. Combining #35 and #38 solved my issue on Mix & Match and Acquia Slate.
Trial and error brought me to the following:
More info on CSS clear and overflow property.
Thanks to both #35 and #38 authors.