Undefined & inconsistent use of background colors

Moving this to Drupal 8 and attaching a patch that does the following things:

- give specific background-colors only to errors (red), warnings (yellow) and log entries indicating user interaction (blue)
- remove the IMHO highly misleading background-color green from 'Page not found' and 'Access denied' messages. These have the css-class 'dblog-warning' anyway and appear now in yellow as they should.
- ensure that both even and odd rows get the background colors

The colors are basically the same as in /admin/reports/status so that adds some consistency.

Watchdog page before:

Watchdog page after:

Why are the only changing the color in the date column?

I think that's because you can order the logs page by different columns. Only the currently selected column gets the color highlighting to avoid eye cancer.

D'Oh. The color scheme from the patch works fine in Seven but not so well when Bartik is enabled as the admin theme. The reason: Bartik's zebra striping in tables starts with a darker background color (for odd rows) whereas Seven's starts with a lighter one.

I'm starting to wonder if this background-coloring of log messages shouldn't be handled by css in individual themes rather than here in core. This way themes could apply their own color schemes. The colors ind admin/reports/status come from Seven theme's own css, I just noticed.

Opinions?

I'd just like to say I hate theming this as well, and think it can be done better. So many themes do zebra striping on table rows and there is always a problem. Some themes totally ignore it because it's such a pain in the ass from a CSS standpoint.

PS - I am tempted to change this to the CSS component, but I believe it needs some design/UX discussion before getting to that point. When this is ready for CSS work can someone please update the component so we can follow/help? Thanks!

The color contrast test passes for all background-colors in this patch. I've used Contrast-A for checking.

Only when sorting by the user column, the backgrounds don't provide enough contrast for the blue link color. So they fail :-(

I think this is Needs Work based on comments #5 through #9.

Also note that the Drupal 8.x patch will need to be rerolled, because the core directory structure for Drupal 8 has now changed. (For more information, see #22336: Move all core Drupal files under a /core folder to improve usability and upgrades). When the patch has been rerolled, please set the issue back to "Needs Review."

If you need help rerolling this patch, you can come to core office hours or ask in #drupal-gitsupport on IRC.

Back to 'Needs work' according to #10

I suggest remove all colors or only keeps these:

RED = Error
Yellow = Warning

what is the meaning of purple.

D8 against Stark theme
#15 for D8, should it remove all color ? and move down to D7 with these colors

#5 & #9, separate issue for other themes. ( I don't know why its only highlighting date column too)

and we can't use multiple classes on D7 (IE6)

I don't know why its only highlighting date column too

It's only the column currently selected for ordering that gets the coloring, and the date column is selected by default.

On a more general note, I now think the coloring should be left out of dblog.css altogether. Let the individual themes decide whether they want to apply coloring to different types of log messages as a visual aid. This stems from the finding in #5 that Bartik uses a different 'striping' than Seven, so a general coloring that takes account of striping isn't possible from dblog.css alone. Either Bartik or Seven would need to override this.

I think it's also debatable if there should be icons indicating the levels of messages. Why not leave this decision to the theme either? That's what a theme is for, right?

Seems to look fine

The screenshots in #2 definitely make a lot more sense.

Committed and pushed to 8.x. Thanks!

Does this also need a backport to D7?