permissions for each role [#870126]

Comment	File	Size	Author
#11	role_permissions7.patch	11 KB	berdir
#8	role_permissions3.patch	10.62 KB	berdir
#7	role_permissions2.patch	10.51 KB	berdir
#6	role_permissions.patch	10.48 KB	berdir
#4	privatemsg_permissions2.patch	13.21 KB	berdir
#1	privatemsg_permissions.patch	9.86 KB	berdir

Comment #1

berdir

German

Switzerland

commented 31 July 2010 at 15:59

Status:

Active

» Needs review

Status	File	Size
new	privatemsg_permissions.patch	9.86 KB

My plan was to allow to configure this with pm_block_user but I agree that doing this based on roles is easier.

Try the attached patch. Note that the existing "write privatemsg to roles" permission has been renamed to "write privatemsg to all roles" to make it clearer.

Log in or register to post comments

Comment #2

BenK commented 8 August 2010 at 18:20

Subscribing to help with testing...

Log in or register to post comments

Comment #3

BenK commented 16 August 2010 at 23:51

Status:

Needs review

» Needs work

Hey Berdir,

I tried the patch in #1 with a bunch of different permission combinations. Everything seems to be working great.

The only bug/issue I found dealt with the autocomplete: Currently, even if a user only has permission to send to one role, he is able to see all roles in the "To" autocomplete. So it seems we need to update the autocomplete for these more granular permissions.

Also, here are the messages that are currently displayed when a user tries to send to a role that he doesn't have permission to send to:

You must include at least one valid recipient.
The following users will not receive this private message: authenticated user [role]

But neither of these messages actually tells the user what the problem is... that he doesn't have permission for sending to that particular role. Perhaps we also include a message that says something like:

'You are not allowed to send messages to the authenticated user role.'

Thoughts?

--Ben

Log in or register to post comments

Comment #4

berdir

German

Switzerland

commented 7 September 2010 at 15:00

Status:

Needs work

» Needs review

Status	File	Size
new	privatemsg_permissions2.patch	13.21 KB

Fixed the problem with the autocomplete.

I think we already discussed the second point, the thing is that while I fully agree with you, that is currently hard to do. The access checking goes through several functions and the function that currently decides if he has access or not can simply return TRUE or FALSE.

Maybe we can try to handle that in a follow up, it hasn't directly to do with this feature, it's something that needs to be changed in privatemsg.module itself first. What I did in the patch however is slightly change the error message to speak of "recipients", not users.