Closed (fixed)
Project:
Panels Everywhere
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Sep 2010 at 10:47 UTC
Updated:
22 Jan 2014 at 22:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sleeping_at-work- commentedI suppose this is the way:
Comment #2
merlinofchaos commentedHmm. Did you try updating CTools at the same time? While I don't think any of the changes I made to PE should be affected by that, it's possible that they will be I suppose.
It's also possible that you just need to clear the theme registry.
Comment #3
sleeping_at-work- commentedJust tried, and no way out. I'm using last -dev release of Ctools and Panels Everywhere, and I've flushed all caches (including theme registry). If I select "Override the page template" I got my site_template working (but not rendering correctly as my theme is supposed to work with its own page.tpl.php).
If I go back to Panels Everywhere 6.x-1.1 everything goes ok (or simply changing the new panels_everywhere.module for the old one)...
Comment #4
merlinofchaos commentedAre you able to put some debugging in PE's page preprocess to see if maybe it's skipping the site template generation for some reason? In particular there's a function that checks to see if it should go to a fallback, that could be involved?
Comment #5
sleeping_at-work- commentedI'd have to debug this (well, I'm more a designer than a programmer, but I'll try). I've tried applying all the patches included in -dev version to the stable release and no problem with them, but the patch in the issue http://drupal.org/node/872260 generates the bug I'm reporting here. So, having a look around I guess the problem comes from here (Am I wrong - ? -),
http://drupal.org/node/872260#comment-3327300
Well, I'd like to use PE without enabling the "Override page template" option (as it was in stable release - to have more control on my page.tpl.php -), it's still possible?
Comment #6
sleeping_at-work- commentedI'd like to suggest to go back from
to
in panels_everywhere.module - to allow activate PE without enabling the "Override page template" for the ones who'd like to use their own page.tpl.php -
Here's a patch I've tested in my local environment, I'm just replacing a couple of lines with the old ones
Does it make sense to you? Don't know if I'm doing right!? (or the module will be supposed to work only if "Override page template" is enabled...?)
Comment #7
robin van emden commentedThe patch at #6 helped out with the site_template issue, but it brought back issue [#866090 ]
Comment #8
robin van emden commentedComment #9
sleeping_at-work- commentedthanks for testing
Comment #10
mcpuddin commentedI have this exact same issue and the patch did not work well for me either. I have attached a cleanup/rework of the already contributed patch to address the issue in comment #7 (basically $registry['original page'] was not being included for non page.tpl.php overrides).
I am marking this as a critical issue because this is crippling to anybody wanting to make a site with panels everywhere by not overriding page.tpl.php.
Comment #11
mcpuddin commentedComment #12
perusio commentedRight on the money. I have the CTools stable release (1.8) and the PE 1.x-dev. It was rather strange. Somehow the default page handler that I placed in
<theme_name>/pages>wasn't being picked by the CTools machinery.I placed the following debug statement in my
page.tpl.phpNothing was printed. Then I reverted back to the stable release of PE, 6.x-1.1, and nothing was printed, although now the template rendered correctly. After applying the patch in #10 to the dev version of PE I get the output of the debug statement:
Comment #13
mcpuddin commentedI'm glad that helped perusio ! Since you sound like you know code pretty well -- please change the status to "reviewed & tested by the community" so we can get this in the most recent version.
Comment #14
sleeping_at-work- commentedI've tested the patch and it seems ok! I'll test more during the day and I'll report if I find any bug.
Thanks for improving the patch. It would be great to have the "Enable Panels Everywhere site template on a per-theme basis" option available even if the "Override the page template" checkbox is not selected.
Comment #15
sleeping_at-work- commentedHere's a patch (to be tested)
Comment #16
mcpuddin commentedHi Sleeping At Work,
I totally understand your request for patch #15 and I tested your patch however the panels everywhere module hooks in a little deeper than just the admin form. Check out the panels_everywhere_should_override_theme() function.
I'd love to integrate this into this issue and I believe it does relate to the larger issue of making panels everywhere support drupal sites not using 'override page.tpl.php'; however this in itself is a can of worms. Can you create a separate issue for the patch you have in #15 so we can discuss this integration?
Thanks!
James
Comment #17
sleeping_at-work- commentedSure! Thanks for testing, I've posted the patch here: http://drupal.org/node/872260#comment-3856656
Comment #18
sleeping_at-work- commented@mcpuddin
I've tested deeper the patch at #10:
if "Override the page template" checkbox is not selected it's all ok, but try
- selecting "Override the page template"
- selecting "Enable Panels Everywhere site template on a per-theme basis" and your PE-compatible theme
- change theme to a PE-no-compatible theme (e.g., Garland)
Going back to front-end (where I've activated Garland) I get a PHP error - it seems like Panels Everywhere site template is enabled for all themes
I don't know if this is something specific for my local environment, so it'll be great if someone can try by himself and report
Maybe a fix is to remove completely the patch posted by NigelCunningham @ http://drupal.org/node/872260#comment-3341716 and discuss the integration of the option to enable PE on a per-theme basis in the same issue (http://drupal.org/node/872260), as mcpuddin was suggesting
Comment #19
sleeping_at-work- commented.
Comment #20
mcpuddin commentedHi @sleeping-at-work,
Thanks for testing this more deeply. I was unable to reproduce this error -- I am actually in the dev stage of my site and I am using Garland and it works fine for me. Can you let me know what the PHP error is you are getting?
On another note, panels everywhere does not work at all on theme that have a theme_page() function instead of a page.tpl.php -- like Marvin or Chameleon -- because preprocess functions in general don't execute in that case.
Let me know about that PHP error so I can help to resolve this. Thanks again for your work.
Comment #21
sleeping_at-work- commentedHi James,
you're right!, I've tried again and everything seems fine, I think it was something specific for my local environment
Comment #22
sleeping_at-work- commentedHope more people can test the patch @ #10, so that it'll be possible to change the status to RTBC
Comment #23
mcpuddin commentedYou can move it to RTBC, no? or do we need 2 people?
Comment #24
sleeping_at-work- commentedHmmmm, well, maybe it will be better to have more opinions about the patch ( ... unluckily I'm not an "experienced developer" )
http://drupal.org/node/156119
Comment #25
perusio commentedHere, lets RTBC it. We have quorum for such I think.
Comment #26
dan_lennox commentedI recently ran into this same issue. Tested patch in #10 and it worked fine. I also could not reproduce the PHP error from #18.
Comment #27
Letharion commentedAssigning to myself so I remember to take a look at this one later.
Comment #28
kars-t commented+1 for the patch in #10.
It does add "panels_everywhere_page_preprocess" again to the preprocess functions so PE can do its work with a normal theme.
I'd say it should be commited and the issue split up as the feature request for "enable PE for a specific theme even if 'override the template' is not active".
Comment #29
alfthecat commentedsubscribing
Comment #30
Letharion commentedRe-assigning to myself as a reminder.
Comment #31
alfthecat commentedConfirming patch #15 works!
Comment #32
LGLC commentedPatch #10 works brilliantly for me, too. Thanks!
Comment #33
alysaselby commentedHas this issue been committed? If so, can anyone tell me to which version it was added. I've been using the patch in #10 since 2010, but cannot find a thread to verify that it has been added to a future version.
thanks,
Comment #34
damienmckennaShortened the title and rerolled the patch; I did change the whitespace slightly, to make the code fix the coding standards better, but as that was all I'm leaving the status as-is.
Comment #35
damienmckennaCommitted. Thank you for your patience.