It had be nice if we could make minor theme colors variation after choosing a color preset.

In other way, if farbtastic colors choice could just update itself after a preset has been chosen, with preset's color set?.

CommentFileSizeAuthor
#22 farbtastic-scheme-focus-91985-22.patch512 bytesbabruix
#17 farbtastic-scheme-focus-91985-17.patch997 bytesbdragon
#10 color_6.patch525 bytesbdragon
#4 color.js_0.patch504 bytesGurpartap Singh
#1 color.js.patch635 bytesGurpartap Singh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented
Title: Garland: Update farbtastic choice upon Color set choice » Chance farbtastic sel. on Color set choice
Component: theme system » color.module
FileSize
color.js.patch635 bytes
Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented
Title: Chance farbtastic sel. on Color set choice » Change farbtastic sel. on Color set choice
Status: Active » Needs work
Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented

Here's a patch working as expected, better.

Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented
FileSize
color.js_0.patch504 bytes

all my posts, sorry :(

Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented
Version: x.y.z » 5.x-dev
Status: Needs work » Needs review
Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented

Anyone getting this?

forngren’s picture

forngren CreditAttribution: forngren commented

Can you please explain better what you want do achieve? Perheps I'm just stupid, but I simply don't get it.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Version: 5.x-dev » 6.x-dev
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work

Patch in http://drupal.org/node/91985#comment-150501 contains leading tabs. Please change to two spaces per tab.

bdragon’s picture

bdragon CreditAttribution: bdragon commented
Status: Needs work » Needs review
FileSize
color_6.patch525 bytes

Free reroll (with proper whitespace), courtesy patch bingo.

birdmanx35’s picture

birdmanx35 CreditAttribution: birdmanx35 commented
Version: 6.x-dev » 7.x-dev

Feature request, -> 7.x-dev.

Robin Monks’s picture

Robin Monks CreditAttribution: Robin Monks commented
Status: Needs review » Postponed (maintainer needs more info)

Patch still applies, but, I still don't see what it's trying to achieve. Making needs more info until that can be explained.

Robin

Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented

Consider:

a) A color preset is selected. say bluemarine.
b) Color fields now have new/changed values.
c) But the selection in farbtastic is still pointing to some earlier selection (viz not the same as bluemarine's base color).

The patch sets farbtastic color widget's color selection to selected preset's base color when this preset is selected.

Robin Monks’s picture

Robin Monks CreditAttribution: Robin Monks commented
Title: Change farbtastic sel. on Color set choice » [usability] Set farbtastic form focus to base color after selecting a preset color choice
Status: Postponed (maintainer needs more info) » Needs work

Thank you for the description of the problem. I have updated the title to better reflect the issue as you have described it in comment #13. If you feel this was in error, please feel free to update the title again, it is your issue after all :o)

I'm returning the patch to code needs review as when I tested focus remained on the color preset selector even after selecting another preset.

Robin

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented
Title: [usability] Set farbtastic form focus to base color after selecting a preset color choice » Usability: set farbtastic form focus to base color after selecting a preset color choice
Component: color.module » usability
mfer’s picture

mfer CreditAttribution: mfer commented

subscribe.

bdragon’s picture

bdragon CreditAttribution: bdragon commented
Version: 7.x-dev » 8.x-dev
Component: usability » color.module
Status: Needs work » Needs review
FileSize
farbtastic-scheme-focus-91985-17.patch997 bytes

This is still relevant and the suggested fix still seems reasonable.

Reroll, git style, with a comment explaining why we are calling focus.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

Subscribe, need to come back and test, seems good from first view.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented

#17: farbtastic-scheme-focus-91985-17.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, farbtastic-scheme-focus-91985-17.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Issue tags: +Novice, +Needs reroll

.

babruix’s picture

babruix CreditAttribution: babruix commented
Status: Needs work » Needs review
FileSize
farbtastic-scheme-focus-91985-22.patch512 bytes

New patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: -Needs reroll

Removing tags

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)
Related issues: +#2268955: Deprecate farbtastic library