Closed (fixed)
Project:
Chessboard Renderer
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Dec 2010 at 20:50 UTC
Updated:
3 Jan 2014 at 02:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eric_a commentedThis patch brings down the number of calls from about 16 to 0 or 16 to 4 depending on where the images come from.
Comment #2
eric_a commentedComment #4
eric_a commented#1: chessboard-io-995762-1.patch queued for re-testing.
Comment #6
eric_a commented#1: chessboard-io-995762-1.patch queued for re-testing.
Comment #8
eric_a commented#1: chessboard-io-995762-1.patch queued for re-testing.
Comment #10
eric_a commentedFails due to #996512: D6 contrib project tests: [MySQL] Drupal installation failed..
Comment #11
eric_a commentedCommitted #11.
#1 passes tests locally. Even so there is a problem:
This will assign the class attrribute if width/ height attributes were assigned, which is not always the case if for some reason the size cannot be determined. I'm postponing writing a test for such cases until we remove old API functions and introduce an up-to-date API (and UI) for changing the image directory.
New patch is written to fix this and be more readable. Passes test locally.
Comment #12
eric_a commentedThese two comments are just... not good.
Automated testing should be back now... Let's see.
Comment #13
eric_a commented#1: chessboard-io-995762-1.patch queued for re-testing.
Comment #15
eric_a commentedYes! Drupal 6 install code is fixed and patch testing is back again *after* committing to the branch. Of course the patches do not apply anymore after having been committed. (Tested locally. And the branch is fine according to qa.)