Following up with proweb.ua's request on #1793108-4: Filter integration with wysiwyg:

it works with cke4 ?

See follow up reply at: #1793108-6: Filter integration with wysiwyg, to put it short, let's wait on:
#1853550: Ckeditor 4.0 - The version of CKEditor could not be detected.
to stabilize, then let's proceed to additional testing and debugging if required.

Any feedback, questions, testing or comments would be highly appreciated.

Thanks very much to all in advance.

Comments

DYdave’s picture

Quick follow-up on this issue:

Did a round of testing and debugging see: #1986878: not work with last CKEditor 4.

While working on fixing this issue, quick fixes of coding standards were committed at 4a2be64: mostly wrong indents or end of line white spaces.

Since wysiwyg-7.x-2.x-dev has the patch for the support of CKEditor 4.x, I guess there shouldn't be any more problems related to this ticket.
But let's keep this issue active for a while to see if any other problems are reported.

Thanks very much to all in advance.

  • DYdave committed 8ca23d9 on 7.x-1.x
    Issue #1890908 by DYdave: Minor update and cleanup of...
DYdave’s picture

Alright!

So it's already been almost a year and a half since this issue was last updated and I guess it is probably safe to assume that if more issues related with CKEditor 4 had been found, they would most likely have been reported, either in #1793108: Filter integration with wysiwyg or in Collapse Text Wysiwyg issue tracker in general.

I seized the opportunity to answer this ticket, to take another fresh look at module's code, also trying to prepare for finally merging with the Collapse Text module and I actually found a couple of small details that could still be further improved.

In the implementation of hook_wysiwyg_plugin, in collapse_text_wysiwyg.module:

  • Not sure how the 'description' key could still have been there, since it seems it was removed from the Wysiwyg API at 6692938, on August 9, 2009... so I got it merged with the description text under 'buttons'.
  • I can't seem to recall either where the 'name' key could have come from, since it doesn't appear anywhere in any revision of the Wysiwyg API for the 7.x-2.x branch (Perhaps these two keys were still remains from a previous version on Drupal 6...).
  • Added a URL to the plugin's homepage.
  • Added inline comments for each key of the plugin's array.

Therefore, I went ahead and had these changes committed against collapse_text_wysiwyg-7.x-1.x at 8ca23d9.

Which I would assume should pretty much wrap up this issue, so I allowed myself to mark it as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with the changes committed at 8ca23d9 (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on any of the latest code changes or this ticket in general, I would be glad to provide more information or explain in more details.

Thanks in advance to everyone for your testing, reviews, reporting and feedback.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.