It looks like a fair amount of the toolbar code that this module interacts with is gone due to #2217985: Replace the custom menu caching strategy in Toolbar with Core's standard caching. and likely the admin_toolbar module no longer works with the latest D8 git checkout.

CommentFileSizeAuthor
#9 admin_toolbar-chase-head-2533420-9.patch4.93 KBtwistor
#4 2533420-chase-head.patch4.52 KBDave Reid
#2 2533420-chase-head.patch4.27 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

This seems to be working in my initial testing (not with admin_toolbar_tools enabled, because I'm not sure what's up with all the un-properly-namespaced functions going on in that module).

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Active » Needs review
FileSize
2533420-chase-head.patch4.27 KB
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

Actually, seems to be working with admin_toolbar_tools as well!

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
FileSize
2533420-chase-head.patch4.52 KB

Better docs.

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2536324: Undefined function being called _toolbar_get_user_cid

Seems to work fine.

Very nice cleanup.

twistor queued 4: 2533420-chase-head.patch for re-testing.

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented

This was partially fixed in http://cgit.drupalcode.org/admin_toolbar/commit/?id=9e2bdf5

But, the proposed patch is much better.

Let's see if it still applies.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2533420-chase-head.patch, failed testing.

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Status: Needs work » Needs review
FileSize
admin_toolbar-chase-head-2533420-9.patch4.93 KB

This was just a re-roll. Dave Reid should get commit credit.

matio89’s picture

matio89 CreditAttribution: matio89 commented
Status: Needs review » Fixed
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Fixed » Needs review

I don't see this actually has been committed to 8.x-1.x branch?

@matio89: Usually some kind of short message indicating why an issue has been fixed is helpful for people in your issue queue.

  • matio89 committed e33be89 on 8.x-1.x authored by twistor 
    Issue #2533420 by Dave Reid, twistor: Chase HEAD changes in toolbar

  • matio89 committed 0426e20 on 8.x-1.x authored by Dave Reid 
    Issue #2533420 by Dave Reid: Chase HEAD changes in toolbar
matio89’s picture

matio89 CreditAttribution: matio89 commented

Hi Dave,
I verified the patch, i's perfect and i commited in 8.x-1.x branch.
Thanxs.

eme’s picture

eme CreditAttribution: eme commented

Thanks matio89. This is perfect like that. :-)

matio89’s picture

matio89 CreditAttribution: matio89 commented
Status: Needs review » Fixed

You're too quick to see the commit !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.