Authcache Builtin Cache Expiration v2 fails to expire urls if there is an associated url alias. The problem is that only internal paths are cleared instead of the alias paths. This issue does not exist in Authcache Builtin Cache Expiration v1 because there the $urls parameter to hook_expire_cache already contains the aliased paths and not the internal ones.

CommentFileSizeAuthor
#2 2177265-fix-v2-expiration-for-both-internal-path-and-alias.patch1015 bytesgokulnk
#1 2177265-fix-v2-expiration-with-alias.patch708 bytesznerol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Active » Needs review
FileSize
2177265-fix-v2-expiration-with-alias.patch708 bytes
gokulnk’s picture

gokulnk CreditAttribution: gokulnk commented
Issue summary: View changes
FileSize
2177265-fix-v2-expiration-for-both-internal-path-and-alias.patch1015 bytes

Ran into the same scenario in a recent project. Did check the patch and it works great.

Just had one concern. Assume that path module is enabled but global redirect module is not enabled. Then there can be two caches for the same node. Say node/2 and aboutus. As an end user I would expect that both the caches are cleared.

Have created a patch for the same logic. Please review.

Note : Since I am adding a new path thought it was more appropriate to do it in the

Status: Needs review » Needs work

The last submitted patch, 2: 2177265-fix-v2-expiration-for-both-internal-path-and-alias.patch, failed testing.

znerol’s picture

znerol CreditAttribution: znerol commented

Thank you for the feedback and for the code. If I'm not mistaken the patch for the Expire module in #1978642-5: Pass node language to determine alias does exactly what you are proposing. Whenever the next version of the Expire module is released, we'd need to revert all changes introduced in this issue anyway.

Therefore instead of patching authcache, I'd rather recommend to patch Expire (or use their dev-version) for the moment.

gokulnk’s picture

gokulnk CreditAttribution: gokulnk commented

Agreed. Thanks for the great module :)

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Needs work » Closed (works as designed)

Cache Expiration 7.x-2.0-rc2 which includes #1978642: Pass node language to determine alias has been released a while ago. I think this is fixed now.

Samlet9908’s picture

Samlet9908 CreditAttribution: Samlet9908 commented

Sorry but I'm using the the latest builds of both Authcache and Cache Expiration with Memcached as the cache backend. If I enable 'external expiration' in Cache Expiration, when editing a node, it gives me a blank screen and does not save the node. I'm using aliases.

znerol’s picture

znerol CreditAttribution: znerol commented

This issue is closed, please open a new support request and do not post on multiple random issues.