hook_system_info_alter() ought to do it.

CommentFileSizeAuthor
#20 786208-bad_judgement_php-d6-diff.patch228 bytesdeekayen
#20 786208-bad_judgement_php-d7-diff.patch221 bytesdeekayen
#19 786208-bad_judgement_php-d6.patch332 bytesdeekayen
#19 786208-bad_judgement_php-d7.patch341 bytesdeekayen
#2 php.patch666 bytescatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

LOL!

You're right! Of course, you would have to enable this module in order to get the dependency inserted via that hook.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs review
FileSize
php.patch666 bytes

Details, details.

edit: OMG patch size!

mbutcher’s picture

mbutcher CreditAttribution: mbutcher commented
Status: Needs review » Reviewed & tested by the community

This is the greatest patch I have ever seen in my entire life.

In the true spirit of this module, I'm marking it reviewed and tested even though I neither reviewed it nor tested it.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

+1lolz

seutje’s picture

seutje CreditAttribution: seutje commented

this is no coincidence, greater powers are at work here

SeanBannister’s picture

SeanBannister CreditAttribution: SeanBannister commented

LMAO, awesome!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

+1. will buy again. A truly positive addition to the module space.

Nick Lewis’s picture

Nick Lewis CreditAttribution: Nick Lewis commented
Status: Reviewed & tested by the community » Needs review

Guys I dunno. What about the themers?

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Nice.

If you like this sort of humor, join us at Drupal for Evil

Nick Lewis’s picture

Nick Lewis CreditAttribution: Nick Lewis commented
Status: Reviewed & tested by the community » Needs review

Don't trump me Moshe.

Nick Lewis’s picture

Nick Lewis CreditAttribution: Nick Lewis commented
Status: Needs review » Reviewed & tested by the community

redintegro est recipero

Nick Lewis’s picture

Nick Lewis CreditAttribution: Nick Lewis commented

...

Nick Lewis’s picture

Nick Lewis CreditAttribution: Nick Lewis commented
Status: Reviewed & tested by the community » Fixed

There's known workaround where module developers can directly edit the module to make this work. Good work team.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

Now that the consensus is to not commit this, I've committed it.

http://drupal.org/commitlog/commit/14044/ed4c6ecd16876af0b6524225e27a381...

Nick Lewis’s picture

Nick Lewis CreditAttribution: Nick Lewis commented
Status: Fixed » Active

I believe we need a feature that rebuilds theme cache on every page load. I'm putting it in this issue since this is where the discussion is happening.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

CAUTION, CAUTION.

IRONY ALERT: there are at least two projects that do that already.

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented
Category: feature » bug
Priority: Normal » Critical

Nick, I really think we need it rebuilt *twice* each page load - what if I make some changes while the page is loading? I don't want those not to propagate through...

mbutcher’s picture

mbutcher CreditAttribution: mbutcher commented

+1

Oh, and I have something else to say. The name of this module should be changed to something else. I don't know what though.

deekayen’s picture

deekayen CreditAttribution: deekayen commented
FileSize
786208-bad_judgement_php-d7.patch341 bytes
786208-bad_judgement_php-d6.patch332 bytes

Here's some stuff you can add to your drush make file:

Example stub:

projects[drupal][type] = core
projects[drupal][download][type] = git
projects[drupal][download][url] = http://git.drupal.org/project/drupal.git
projects[drupal][download][branch] = 6.x
projects[drupal][patch][] = "http://drupal.org/files/786208-bad_judgement_php-d6.patch"
deekayen’s picture

deekayen CreditAttribution: deekayen commented
FileSize
786208-bad_judgement_php-d7-diff.patch221 bytes
786208-bad_judgement_php-d6-diff.patch228 bytes

I just learned core patches in drush make are regular diffs, not git ones.

core = 6.x
api = 2
projects[drupal][type] = core
projects[drupal][patch][] = "http://drupal.org/files/786208-bad_judgement_php-d6-diff.patch"
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

PHP module no longer exists in Drupal 8. You're welcome.

Discussion about having it use Bad Judgement: #2089647: Improve documentation about PHP security implication

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented

c.f. #2106561: Missing dependency on bad judgement

laboratory.mike’s picture

laboratory.mike
Primary language English
CreditAttribution: laboratory.mike commented
Issue summary: View changes

#15:

Fixing here: #2455085: No Hooks?

Because adding hooks totally has to do with theming. And this thread.