Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The second user_save() triggers the account activation email, which is not useful and sometimes confusing. Caused by #574194: User feature - import list of subsite accounts to master site
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | bakery.diff | 901 bytes | drumm |
Comments
Comment #1
drummComment #2
gregglesNow deployed on g.d.o for testing.
Comment #3
drummHow's the testing going?
Comment #4
gregglesI had only heard one complaint about this in the ~weeks that it was buggy and since deploying it I've heard nothinng. Not sure that's valid.
Comment #5
drummFor association and API, I turned off all account activation emails from user module, after getting ~2-3 complaints in a day. It is confusing because you are already logged in and do not need additional instructions.
Comment #6
gregglesI'm not sure about the idea of not needing additional instructions. That's true for some sites but not all. On g.d.o I changed the mail to include pointers to important pages for g.d.o. But yes, in general we shouldn't be sending this mail - I'll try to actually review soon unless someone else gets it first.
Comment #7
drummThe current behavior of the notifications is an unintentional side-effect of #574194: User feature - import list of subsite accounts to master site.
Bakery should provide its own notifications UI for any possible notifications. They are different enough from the ones in core.
Comment #8
coltraneI was concerned about an account being blocked on the master and this not respecting it, but if the status is set to be synced, then it should be correctly handled.
I think this is RTBC.
Comment #9
gregglesNow fixed - http://drupal.org/cvs?commit=504608
Comment #10
drummThis looks good on the 7.x-2.x branch.