Problem/Motivation

After an update to Drupal 10.5.0 the CKEditor is unavailable when creating / editing nodes. The CKEditor is available again after uninstalling this module. Reproducible by re-installing the module under Drupal 10.5.0. No information is logged to the status report.

Steps to reproduce

Update to Drupal 10.5.0 and install module.

CommentFileSizeAuthor
#5 3531224-5.patch25.46 KBjasonsavino

Issue fork ckeditor_responsive_table-3531224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gkaas created an issue. See original summary.

ed2908’s picture

ed2908 commented

Same. I'm seeing this error on Drupal 10.5.1:

TypeError: e.icons is undefined
    n https://my.ddev.site:8443/modules/contrib/ckeditor_responsive_table/js/build/responsiveTable.js?syor2z:1
    _createFormView https://my.ddev.site:8443/modules/contrib/ckeditor_responsive_table/js/build/responsiveTable.js?syor2z:1
    init https://my.ddev.site:8443/modules/contrib/ckeditor_responsive_table/js/build/responsiveTable.js?syor2z:1
    promise callback*./packages/ckeditor5-core/src/index.ts/init/m/< https://my.ddev.site:8443/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=45.2.0:5
    m https://my.ddev.site:8443/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=45.2.0:5
    init https://my.ddev.site:8443/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=45.2.0:5
desix75’s picture

desix75 commented

I have the same error on drupal 11.2.2 and ckeditor_responsive_table 1.0.6,
if I remove it from the ckeditor5 toolbar then the editor works perfectly again.

marelpup’s picture

marelpup commented

There is the same issue on this module
https://www.drupal.org/project/ckeditor_abbreviation/issues/3531259

fixed with

https://git.drupalcode.org/project/ckeditor_abbreviation/-/merge_request...

jasonsavino’s picture

jasonsavino commented
StatusFileSize
new 3531224-5.patch25.46 KB

Uploading a patch file until the solution has been implemented in the module.

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented

Confirmed the issue on a fresh 10.5 install. Thanks all for reporting! I'll apply @jasonsavino's patch to an MR, test that, and open for community review. Thanks @jasonsavino!

bronzehedwick opened merge request !18

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented

Added an MR based on @jasonsavino's patch. Tested working locally on Drupal 10.5 and 11.1. The differences between the MR and the patch are some small code style clean up, installing the ckeditor icon npm package, and bumping the module's ckeditor dev dependencies to match the latest version. Needs some thorough testing because of the upgrades.

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented
Status: Active » Needs review

javi-er made their first commit to this issue’s fork.

javi-er’s picture

javi-er commented

I tested it in my local and it's working well!

javi-er’s picture

javi-er commented
Status: Needs review » Reviewed & tested by the community

javi-er’s picture

javi-er commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.