Problem/Motivation

  • Reactor the forms in Cloud Dashboard to make it easier to implement CxUD such as AWS Cloud.

Issue fork cloud-3271378

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !799

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I refactored codes in Cloud Dashboard and Cloud module. Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. Basically it looks good. I posted my comments. Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I fixed the source code. Please review it again. Thanks!

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Needs work

@yas @RyoYamashita

Thanks for the code. It almost looks good to me, but there is one thing.

About the word "Openstack", I think it should be changed to OpenStack for all the file names and class names. How do you think about it?

sekinet’s picture

sekinet commented

@yas @RyoYamashita

Thank you for the refactoring. It looks good to me.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@guan @yas

It was indeed causing spelling inconsistencies, which have been corrected.
Please review it again.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Needs work

@RyoYamashita

I think the names of files below should be changed to OpenStack too.

OpenstackCreatePage.tsx
OpenstackDeletePage.tsx
OpenstackEditPage.tsx
Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@guan

Sorry, The change in the case of the filename was not committable. I fixed it.

xiaohua guan’s picture

xiaohua guan commented

@RyoYamashita @yas

Thanks for your code. It looks good to me now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor code of CxUD forms in Cloud Dashboard » Refactor the CxUD forms in Cloud Dashboard

  • yas committed 405cf16 on 5.x authored by Ryo Yamashita 
    Issue #3271378 by Ryo Yamashita, yas, Xiaohua Guan, sekinet: Refactor...

  • yas committed f7b5168 on 4.x authored by Ryo Yamashita 
    Issue #3271378 by Ryo Yamashita, yas, Xiaohua Guan, sekinet: Refactor...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Ryo Yamashita opened merge request !820

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work
Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Fixed

Issue #3272661 contained the equivalent of MR 820, so I will re-fix this ticket.

Ryo Yamashita closed merge request !820

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.