Problem/Motivation

  • Set the same value of its flavor to the instance type of a launch template

Issue fork cloud-3306702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
Title: Set the same value of its flavor to the instance type of a launch template » Refactor openstack instance and launch template

Xiaohua Guan opened merge request !1245

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for the patch. I tested it and it looks good.

@kumikoono

What do you think?

Thanks

kumikoono’s picture

kumikoono commented
Status: Needs review » Needs work

Thanks for the patch.
The instance type still appears on the view and list of a launch template. Can you remove them?

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@kumikoono

Thanks for your comment. I've fixed it. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Can you please fix the following coding check error? Thanks

FILE: ...c/Plugin/cloud/launch_template/OpenStackLaunchTemplatePlugin.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I've fixed it. Please take a look again. Thanks.

kumikoono’s picture

kumikoono commented

This looks good to me. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for your review.

@xiaohua-guan

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor openstack instance and launch template » Fix the Flavor labels in OpenStack instance detail view and launch template
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@xiaohua-guan

Can you please rebase the patch? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix the Flavor labels in OpenStack instance detail view and launch template » Fix the labels in OpenStack instance detail view and launch template (Flavor and Image name)
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Reviewed & tested by the community

@yas

I've rebased the code. Please check it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed ebc1354 on 5.x authored by Xiaohua Guan 
    Issue #3306702 by Xiaohua Guan, yas, kumikoono: Fix the labels in...

  • yas committed e78c34b on 4.x 
    Issue #3306702 by Xiaohua Guan, yas, kumikoono: Fix the labels in...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.