Coding Standards Meeting Tuesday 2024-10-08 2100 UTC [#3479501]

Hello all, it’s time for the fortnightly coding standards meeting.

This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.

Current ping list: @catch, @larowlan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

larowlan	hiya
kimb0	konichiwa! :wave::skin-tone-2:
Björn Brala (bbrala)	Good morning.
longwave	:wave: catching up

1️⃣ What topics do you want to discuss? Post in this thread and we’ll open threads for them as appropriate.

larowlan

should we try and recruit more members? everyone on the team wears multiple hats so it maybe some new members would help

2️⃣ Action items

2️⃣.1️⃣ Approve minutes for previous meeting(s)

quietone	Needs Review[#3464886]
quietone	Needs Review[#3464886]
quietone	And there are 4 at RTBC
quietone	Actually "Coding Standards Meeting Wednesday 2024-09-25 0900 UTC" still needs to have the meeting converted to an issue
Björn Brala (bbrala)	I'll try and find time today to do some maintenance
Björn Brala (bbrala)	CLeaned up the meetings. Also parserd one that now needs review:#3476644: Coding Standards Meeting Wednesday 2024-09-25 0900 UTC#comment-15806837

2️⃣.2️⃣

quietone	@quietone to do[#3467997]
quietone	This is now published.

3️⃣ RTBC Issues

3️⃣.1️⃣ Enums #3339746: Coding style for PHP Enumerations (edited)

quietone

See comments #58 and #59

3️⃣.2️⃣ Elvis operator[#3422530]

quietone	This needs review by the committee
Björn Brala (bbrala)	In all for this. We have the text, check, change record. Seems ready to move on.
catch	Yep +1

3️⃣.3️⃣ Use statements[#1624564]

quietone	I would prefer to shorted the proposed text by removing "in a case-sensitive order which places all uppercase letters before the lowercase letters. Note also that backslash \ precedes underscore _".
quietone	For, I expect that anyone working with code understands 'case-sensitivity' and alphabetical. And even if they don't, or forget, they know how to find out.
Björn Brala (bbrala)	I'm not too sure case sensitivity order is that clear if we don't mention it. Alphabetical could be either or. I'd be OK to remove the whole explainantion, but would still do "alphabetical, case-sensitive..." since otherwise it could be either
borisson_	I agree, we need to add the case sensitivity, because in my head lowercase goes before uppercase, but in practice it's the other way around I learned earlier this week. https://drupal.slack.com/archives/C02LJCF78E8/p1727962811569029

4️⃣ Committee membership, from @larowlan (edited)

quietone	Yes, the multiple hats can be a challenge.
quietone	The current members have been in the role for more that a year. This may be a suitable time to check amongst ourselves to see if each of us wish to continue?
larowlan	I wonder if @mstrelan has an interest
mstrelan	Is there a list of responsibilities somewhere?
quietone	I've started work on that in the form of a job description, see then next meeting item. 5️⃣

5️⃣ Committee job description (edited)

quietone	Related to 4️⃣ is to have a job description for the team. I think this is important to detail that tasks involved in the job so that there are no misconceptions.
quietone	I started one and it needs input from anyone interested in coding standards and how the committee works, https://docs.google.com/document/d/1612Bx_qBQJaqkkNeAvoeHZjBg3QBKybq8aXA...

Participants: