The product variation listing is not paginated.

When we have a lot of variations - query $product->getVariations() can fail on the variation listing page, so it needs to paginate this listing.

CommentFileSizeAuthor
#5 commerce_product-add_pagination_to_product_variations_listing-3385829-3.patch1.21 KBr_cheh
#2 commerce_product-add_pagination_to_product_variations_listing-3385829-1.patch760 bytesr_cheh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

r_cheh created an issue. See original summary.

r_cheh’s picture

r_cheh CreditAttribution: r_cheh commented
FileSize
commerce_product-add_pagination_to_product_variations_listing-3385829-1.patch760 bytes
idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Active » Needs review
jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro for Matsmart commented

Out of curiosty, any reason not to use a view? Rather than the default variation list builder?

r_cheh’s picture

r_cheh CreditAttribution: r_cheh commented
FileSize
commerce_product-add_pagination_to_product_variations_listing-3385829-3.patch1.21 KB

Add getEntityIds() functions for product variation list builder

r_cheh’s picture

r_cheh CreditAttribution: r_cheh commented
r_cheh’s picture

r_cheh CreditAttribution: r_cheh commented
r_cheh’s picture

r_cheh CreditAttribution: r_cheh commented

Yes, because this listing used as default listing of product variation on admin page

r_cheh’s picture

r_cheh CreditAttribution: r_cheh commented

So, this patch doesn't work correctly because we can't load variation weight and sort by it (weight value isn't a field from the database, just a class property), and table drags don't work correctly