Problem/Motivation

When menu_position and context modules are enabled we get fatal error:

TypeError: Argument 5 passed to Drupal\menu_position\Menu\MenuPositionActiveTrail::__construct() must implement interface Drupal\Core\Entity\EntityTypeManagerInterface, instance of Drupal\context\ContextManager given, called in /var/www/html/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 in Drupal\menu_position\Menu\MenuPositionActiveTrail->__construct() (line 48 of modules/contrib/menu_position/src/Menu/MenuPositionActiveTrail.php).

Steps to reproduce

- Install and enable menu_position module 1.0.0-beta1
- Install and enable context module 4.1.0

Proposed resolution

Check if class is sub_class in ContextServiceProvider, like it should since this commit

Remaining tasks

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork context-3231646

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vlad.dancer created an issue. See original summary.

vlad.dancer opened merge request !20

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer as a volunteer and at Xspace, Drupal Ukraine Community for Globalbility commented
Status: Active » Needs review

The change was introduced in #3171741: Context module: "Menu Reactions" will not work because menu.active_trail has a different menu service provider.

paulocs made their first commit to this issue’s fork.

  • paulocs committed 1edab92 on 8.x-4.x authored by vlad.dancer 
    Issue #3231646 by vlad.dancer: Incompatibility with menu_position module
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented

Thanks!

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.